-
Notifications
You must be signed in to change notification settings - Fork 822
Merging changes from the internal fork #6508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting ready for th 9.6 release ---- #### AI description (iteration 1) #### PR Classification This PR prepares the repository for the 9.6 release by upgrading dependency versions and refining build pipeline configurations. #### PR Summary The PR updates key dependency versions and adjusts pipeline settings to support a stable 9.6 release build. - `/eng/Version.Details.xml`: Upgraded dependency versions from 9.0.5 to 9.0.6 with corresponding SHA updates. - `/eng/Versions.props`: Updated version properties for major dependencies (and LTS versions bumped to 8.0.17) while enabling package stabilization and setting DotNetFinalVersionKind to release. - `/NuGet.config`: Revised package source definitions and disabled package source mappings for internal feeds. - `/azure-pipelines.yml` & `/eng/pipelines/templates/BuildAndTest.yml`: Removed the CodeCoverage stage and added tasks to set up private feed credentials with integration tests temporarily skipped. - `/Directory.Build.props`: Suppressed the NU1507 warning for internal branch builds. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…tag (dotnet#6494) This ports commit 04bd588 into the 9.6 release branch. See: [Fix name of genai input/output tokens tag (dotnet#6494)](dotnet#6494)
Automated cherry-picks ---- #### AI description (iteration 1) #### PR Classification This PR implements a new OpenAIAssistantChatClient along with updated streaming response handling and enhanced integration tests. #### PR Summary This update introduces a new chat client and refines conversation management and error handling for OpenAI responses while expanding test coverage. Key changes include: - **`src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIAssistantChatClient.cs`**: Added a new experimental chat client that integrates with AssistantClient, supports streaming responses, tool result processing, and uses reflection to access internal endpoints. - **`src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIResponseChatClient.cs`**: Updated response streaming logic to correctly propagate conversation IDs, attach raw representations, and improve error handling and role mapping. - **`src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIClientExtensions.cs`**: Introduced an extension method to expose AssistantClient as an IChatClient, enabling direct integration with the new chat client. - **Test files under `test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests` and related integration tests**: Added and modified tests to validate the new client functionality and updated response behavior. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
/azp run extensions-ci |
Azure Pipelines successfully started running 1 pipeline(s). |
stephentoub
reviewed
Jun 11, 2025
<TemplatePackageVersion_MicrosoftExtensionsHttpResilience>$(Version)</TemplatePackageVersion_MicrosoftExtensionsHttpResilience> | ||
<TemplatePackageVersion_MicrosoftExtensionsAI>9.6.0</TemplatePackageVersion_MicrosoftExtensionsAI> | ||
<TemplatePackageVersion_MicrosoftExtensionsAI_Preview>9.6.0-preview.1.25310.2</TemplatePackageVersion_MicrosoftExtensionsAI_Preview> | ||
<TemplatePackageVersion_MicrosoftExtensionsHttpResilience>9.6.0</TemplatePackageVersion_MicrosoftExtensionsHttpResilience> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for the release/9.6 branch I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this will be undone on the PR against main.
stephentoub
approved these changes
Jun 11, 2025
evgenyfedorov2
approved these changes
Jun 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged and not squashed.
Microsoft Reviewers: Open in CodeFlow