Skip to content

Add netstandard2.0 compatibility to Microsoft.Extensions.Telemetry and dependencies #6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 7, 2025
Merged

Add netstandard2.0 compatibility to Microsoft.Extensions.Telemetry and dependencies #6218

merged 11 commits into from
Jul 7, 2025

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Mar 31, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #5022

I have based on the format of this project to change the target frameworks:

extensions/src/Libraries/Microsoft.Extensions.Compliance.Abstractions/Microsoft.Extensions.Compliance.Abstractions.csproj

Line 4 in 56df0c4

<TargetFrameworks>$(NetCoreTargetFrameworks);netstandard2.0;</TargetFrameworks>

Microsoft Reviewers: Open in CodeFlow

@bdovaz bdovaz requested review from a team as code owners March 31, 2025 20:27
@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 7, 2025
@bdovaz
Copy link
Contributor Author

bdovaz commented Apr 21, 2025

What feedback?

@dotnet-policy-service dotnet-policy-service bot removed waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. no-recent-activity 💤 labels Apr 21, 2025
@RussKie
Copy link
Contributor

RussKie commented Apr 21, 2025

The build is failing.

@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 21, 2025
@bdovaz
Copy link
Contributor Author

bdovaz commented Apr 22, 2025

@RussKie I don't understand the error if the only thing I have changed is the target frameworks. The errors are very similar to each other:

.dotnet\sdk\9.0.104\Microsoft.Common.CurrentVersion.targets(2413,5): error MSB3277: (NETCORE_ENGINEERING_TELEMETRY=Build) Found conflicts between different versions of "Microsoft.Extensions.DependencyInjection.Abstractions" that could not be resolved.

@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
@evgenyfedorov2
Copy link
Member

Please generate the suppressions file with dotnet pack <your sln file> /p:ApiCompatGenerateSuppressionFile=true switch

@evgenyfedorov2 evgenyfedorov2 merged commit 63ede02 into dotnet:main Jul 7, 2025
6 checks passed
@bdovaz bdovaz deleted the netstandard-telemetry branch July 7, 2025 12:20
@bdovaz bdovaz mentioned this pull request Jul 7, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evgenyfedorov2 evgenyfedorov2 evgenyfedorov2 approved these changes

Assignees

@bdovaz bdovaz

Labels
area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Http.Resilience .NET Standard compatible
4 participants
@bdovaz @RussKie @evgenyfedorov2 @bdominguez