Skip to content

Conversation

@SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Oct 11, 2024

Microsoft Reviewers: Open in CodeFlow

@stephentoub
Copy link
Member

How did this get through CI? Multiple parallel prs?

@eiriktsarpalis
Copy link
Member

It's also being removed here: https://github.com/dotnet/extensions/pull/5510/files

@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Oct 11, 2024

How did this get through CI? Multiple parallel prs?

#5507 may have been in flight at the same time as #5505. But I haven't done enough investigation to prove this is the cause.

It's also being removed here: https://github.com/dotnet/extensions/pull/5510/files

Great, thanks. Let's just merge whichever one of the PRs is ready first, so as to unblock the build.

@SteveSandersonMS SteveSandersonMS merged commit a8e910a into main Oct 11, 2024
@SteveSandersonMS SteveSandersonMS deleted the stevesa/fix-build-remove-using branch October 11, 2024 16:18
@luisquintanilla luisquintanilla added the area-ai Microsoft.Extensions.AI libraries label Oct 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants