Skip to content

Conversation

AndriySvyryd
Copy link
Member

Fixes #34485

@AndriySvyryd AndriySvyryd requested a review from a team September 30, 2025 23:45
@roji
Copy link
Member

roji commented Oct 2, 2025

@AndriySvyryd didn't we say it's maybe OK to keep these tests as we'll be moving test running to another pipeilne altogether?

@AndriySvyryd
Copy link
Member Author

@AndriySvyryd didn't we say it's maybe OK to keep these tests as we'll be moving test running to another pipeilne altogether?

It might be OK from the perspective that we won't get alerts. But what's the point of testing against an obsolete and unlisted package?

@AndriySvyryd AndriySvyryd force-pushed the Issue34485 branch 2 times, most recently from fe39330 to b3581c5 Compare October 2, 2025 19:12
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing quite a few people may be still using it (as it's the last free version), and it does give us some coverage in terms of detecting breaking changes which also potentially affect other packages too (like the newer Duende package). But the comment was also from the perspective of what we actually gain by removing it (like why not leave it).

But in any case, am OK with removing if you prefer.

@AndriySvyryd AndriySvyryd merged commit 1d81f91 into main Oct 3, 2025
7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue34485 branch October 3, 2025 09:08
@AndriySvyryd
Copy link
Member Author

But the comment was also from the perspective of what we actually gain by removing it (like why not leave it).

Less dependencies -> less maintenance cost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EFCore.AspNet.Specification.Tests dependencies
2 participants