[release/8.0] Improve the relationship cycle breaking logic to detect cycles even when not starting on one. #32598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32422
Port of #32573 and #32593
Description
The issue here is that when looking for foreign key property configuration we only detected relationship cycles if the initial property was part of the cycle. The fix is to keep updating the marker property as we traverse the relationships in increasing intervals. Additionally, we now detect multiple relationship chains that end with incompatible conversions.
Customer impact
Exception when trying to use a model that has a relationship cycle with a dangling relationship. The intended workaround of specifying the configuration explicitly doesn't work with migrations as this configuration is not stored.
How found
Customer report on 8.0.
Regression
Yes.
Testing
Tests added.
Risk
Low and quirked.