[release/7.0] Treat required owned entities on derived types as optional. #31949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this going into 8.0 too? it seems the same there. just asking as that is actually a tighter timeline, unless you wait for 8.0.1 |
Yes, #31950 |
maumar
approved these changes
Oct 4, 2023
|
@AndriySvyryd can you take a look at the merge conflict? |
AndriySvyryd
force-pushed
the
Issue31107
branch
from
d1a178a to
1c83dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31107
Description
When an owned entity type is required, we assume that it will be present even when selecting the base type.
Customer impact
For models with matching shape the queries that involve the base type of the type containing the required owned type with throw an exception.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added tests.
Risk
Low. Quirked.