[release/7.x] Fixes around IncludeExpression for ExecuteUpdate/Delete (#30571) #30579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fully prune IncludeExpression before ExecuteUpdate, not just for the property lambda * Prune also non-owned Includes Fixes dotnet#30572 Fixes dotnet#30528 (cherry picked from commit 4c6f854)
maumar
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30572
Fixes #30528
Backport of #30571
Description
When an owned entity or auto-include was defined on an entity type, this causes IncludeExpressions to be added to the query tree which interfere with ExecuteUpdate/Delete.
Customer impact
Using ExecuteUpdate/Delete against entities which have owned entities or auto-includes would fail in some major scenarios.
How found
Customer report on 7.0
Regression
No, ExecuteUpdate/Delete are new in 7.0.
Testing
Added regression tests.
Risk
Low: The fix is local to ExecuteUpdate/Delete and is simple. Quirks have been added.