Upgrade to EFCore 7 Results in Unexpected Index Changes

[Mike-E-angelo]

File a bug

Remember:

• Please check that the documentation does not explain the behavior you are seeing.
• Please search in both open and closed issues to check that your bug has not already been filed.

I did a search for the following: All containing indexes must be removed or redefined before the property can be removed. and this did not return anything so I am filing a new issue here to investigate.

Additionally, I also did a search for "index" on this document:
https://learn.microsoft.com/en-us/ef/core/what-is-new/ef-core-7.0/breaking-changes

And it does not surface anything obvious to the issue that I am experiencing.

I have attempted to upgrade my model to EfCore 7, using the following command:

dotnet ef dbcontext optimize --output-dir Generated --project Starbeam.Entities.Integration --startup-project Starbeam.Entities.Design

This results in the following error:

The property 'Subject' cannot be removed from entity type 'ResaleOrder' because it is being used in the index {'Subject'} on 'ResaleOrder'. All containing indexes must be removed or redefined before the property can be removed.

Include your code

Ok, so it seems like I need to create a migration to do this? I attempt to do so.

My class looks like this:

[Index(nameof(Subject), IsUnique = true)]
public class ResaleOrder : PurchaseOrder
{
	public ResaleListing Subject { get; set; } = default!;

	public float Royalties { get; set; }
}

So I comment out the [Index(nameof(Subject), IsUnique = true)]. This occurs for other 3 classes throwing this error and after commenting out the indexes I finally get a migration created.

(Note that zero model changes with the exception of the above have been done for my model and worked fantastic in EFCore6)

Within the migration, several indexes + FKs are dropped and recreated -- none of which are related to the classes with indexes I commented above. Here is an example

    /// <inheritdoc />
    public partial class RemoveIndexes : Migration
    {
        /// <inheritdoc />
        protected override void Up(MigrationBuilder migrationBuilder)
        {
 // ... omitted for brevity
            migrationBuilder.DropIndex(
                name: "IX_Transaction_SystemDebit_SourceId",
                table: "Transaction");
migrationBuilder.CreateIndex(
                name: "IX_Transaction_SystemDebit_SourceId",
                table: "Transaction",
                column: "SystemDebit_SourceId",
                unique: true,
                filter: "[SourceId] IS NOT NULL");
 // ... omitted for brevity
        }       
    }

Note that filter: "[SourceId] IS NOT NULL" ... shouldn't this be filter: "[SystemDebit_SourceId] IS NOT NULL" ?

Include stack traces

NA this is upgrading from EFCore6 -> 7.

Include verbose output

As this output exposes a good deal of my model I am not comfortable posting this here, but can do so by request to a secure location if necessary. 👍

Include provider and version information

EF Core version: 7
Database provider: . Microsoft.EntityFrameworkCore.SqlServer
Target framework: (e.g. .NET 7.0)
Operating system: Windows 10
IDE: Microsoft Visual Studio Community 2022 (64-bit) - Preview Version 17.5.0 Preview 1.0

[ajcvickers]

This issue is lacking enough information for us to be able to fully understand what is happening. Please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

[Mike-E-angelo]

Thank you for your reply @ajcvickers unfortunately I am not sure that is viable due to the size of my model. That is, I am not even sure where I would begin with such an effort. This same model worked fine in EFCore6 and I am attempting to upgrade to EFCore7 but running into this issue.

[ajcvickers]

@Mike-E-angelo The problem is that if you can't reproduce it in a way we can investigate with all the code available to you and good knowledge of how it works, then the chances we can do so without these things is practically nil.

[Trapulo]

I don't know if this it same issue, but I have a project running EF Core 6, that after upgrade to EF Core 7.0 fails with:

System.InvalidOperationException: 'The property 'IncomingInvoice' cannot be removed from entity type 'IncomingInvoiceResent' because it is being used in the index {'IncomingInvoice'} on 'IncomingInvoiceResent'. All containing indexes must be removed or redefined before the property can be removed.'

running this line:
builder.Entity().HasOne(t => t.IncomingInvoiceResent).WithOne(t => t.IncomingInvoice).IsRequired().HasForeignKey(i => i.IncomingInvoiceID);

Basically the model has a 1:1 relationship that seems EF Core 7.0 is trying to remove.
No code changes from the project that is running in EF Core 6.0

Any idea?

[Mike-E-angelo]

After some thought @ajcvickers I do have a previous older version of my solution that I have provided for developercommunity issues in the past. I upgraded it to net7.0 along with the latest package references and was able to reproduce this issue.

You can find this here:
https://developercommunity.visualstudio.com/t/Upgrade-to-EFCore-7-Results-in-Unexpecte/10231883

It's not exactly simple, but it allows you to see the issue that is preventing me from upgrading to EfCore7. I am hoping you are able to work with it. 🙏

[ajcvickers]

@Mike-E-angelo So now I have your code. What are the exact steps I should follow to reproduce the issue?

[Mike-E-angelo]

Thank you for your reply and investigation @ajcvickers ... I did provide the steps in the reported issue. Here they are for your review:

[severity:It’s more difficult to complete my work]
This is in regards to this issue:
https://github.com/dotnet/efcore/issues/29847

I have managed to reproduce this on an older solution. Please find it attached as a zip.

load Starbeam.sln
Run dotnet ef dbcontext optimize --output-dir Generated --project Starbeam.Entities.Integration --startup-project Starbeam.Entities.Design

[ajcvickers]

The solution doesn't load for me. I get 154 NuGet errors.

[Mike-E-angelo]

To be certain @ajcvickers I am using Developer PowerShell in my Visual Studio instance, but that is not necessary. As denoted in the original ticket description above the problem occurs when running a dotnet ef command.

How do you usually run dotnet ef commands? Please kindly attempt this and see if you are able to reproduce it this way.

This is what I see when unzipping the provided zip file, and following the directions on my local machine:

[ajcvickers]

In order to investigate I need to be able to build the application. How do I do that?

[Mike-E-angelo]

I was under the impression dotnet ef builds the solution for you. Does it not do this? 🤔 Is there a setting on my machine that is making this occur for me but not for you?

[ajcvickers]

@Mike-E-angelo I need a solution that I can open in Visual Studio (or some other IDE) and work with. Otherwise how am I to debug, rip out code and re-build, and all the other things associated with root-causing an issue?