perf: Reduce exceptions of APIPage deserialization
#10548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #9973.
On current implementation.
APIPagedeserialization internally throw a lot of exception internally.And when the debugger is attached, this will cause performance slow down significantly.
So I've added
IsDeserializableTypemethod that check following context.Utf8JsonReaderinformation1.1. Current
JsonTokenType1.2. Prefetched first
PropertyNameof JSON object. (e.g.h1/api1/facts)And skip deserialization if current context is not valid three pairs combinations.
Additionally, when unknown combination found. (It will be happens when
APIPage's schema is updated)IsDeserializableTypemethod returnstrue.And fallback to default behavior (Try to deserialize and catch exception)
So it works without problems for future updates.