Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 28, 2024

This PR is intended to add support for extensionless HTML URLs for docfx serve command.

Background
GitHub Pages support extensionless URLs. (e.g. https://dotnet.github.io/docfx/docs/basic-concepts)
And other static HTML hosting site also have similar features.

So I thought it's reasonable to support extensionless URLs with the docfx serve command.

Extensionless URL support is partially related to #2865.
It might be better to add options to output extensionless URLs for docfx internal links.

@filzrev filzrev changed the title feat: Allow extensionless HTML URL access feat: Allow extensionless URL HTML file access Nov 28, 2024
@filzrev filzrev force-pushed the feat-allow-extensionless-htmlurl branch from 58072f4 to 8cca247 Compare December 3, 2024 07:55
@filzrev filzrev force-pushed the feat-allow-extensionless-htmlurl branch from 8cca247 to 0f2d784 Compare December 25, 2024 22:23
@codecov
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 79.28%. Comparing base (fe673ec) to head (307c9f4).
Report is 504 commits behind head on main.

Files with missing lines Patch % Lines
src/Docfx.App/RunServe.cs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10436      +/-   ##
==========================================
+ Coverage   74.31%   79.28%   +4.96%     
==========================================
  Files         536      547      +11     
  Lines       23189    23649     +460     
  Branches     4056     4065       +9     
==========================================
+ Hits        17234    18749    +1515     
+ Misses       4853     3730    -1123     
- Partials     1102     1170      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants