feat: Support search.min.js script customize functionality
#10055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we instead expose a callback method in |
Contributor
Author
Currently On my use case. I want to switch search engine from |
filzrev
force-pushed
the
feat-support-search-script-customization
branch
2 times, most recently
from
5d81fce to
1b3917b
Compare
filzrev
force-pushed
the
feat-support-search-script-customization
branch
from
1b3917b to
fc6ca21
Compare
filzrev
force-pushed
the
feat-support-search-script-customization
branch
3 times, most recently
from
34e5291 to
eb69853
Compare
|
Any blockers on this PR? |
filzrev
force-pushed
the
feat-support-search-script-customization
branch
from
eb69853 to
eb962d8
Compare
filzrev
force-pushed
the
feat-support-search-script-customization
branch
from
eb962d8 to
a3ef221
Compare
filzrev
force-pushed
the
feat-support-search-script-customization
branch
from
a3ef221 to
51d13ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to support
search.min.jsscript customization.Currently docfx
moderntemplate bundle scripts todocfx.min.js.So it can't customize search scripts with custom template.
This PR exclude
search.tsfile from bundling by adding following settingsmodern/src/search.ts' asentryPointsto separately createsearch.min.js`../searchimport statement settings by custom esbuild plugin.externalproperty totrueto exclude fromesbuild bundlepathfrom./searchto./search.min.jsAdditionally this PR fix .NET runtime version to .NET 8 (that used bynpm run start)