Skip to content

Update DumpObj command to show TrackedType and TaggedMemory #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2021
Merged

Update DumpObj command to show TrackedType and TaggedMemory #2407

merged 2 commits into from
Jul 2, 2021

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented Jul 2, 2021 •
edited
Loading

Consume new DAC interface introduced in dotnet/runtime#54994

The Tagged Memory address uses DML to create a hyperlink to show memory.

0:000> !DumpObj /d 000001a500015788
Name:        Foo
MethodTable: 00007ff9a72f6098
EEClass:     00007ff9a7309888
CCW:         000001a564470000
Tracked Type: true
Tagged Memory: 0000000012345678 (16(0x10) bytes)
Size:        24(0x18) bytes
File:        C:\Users\arobins\source\repos\TestCoreClr\Hello\bin\Debug\net5.0\Hello.dll
Fields:
None
0:000> dps 0000000012345678 L2
00000000`12345678  ????????`????????
00000000`12345680  ????????`????????

/cc @tommcdon

@AaronRobinsonMSFT AaronRobinsonMSFT requested a review from a team as a code owner July 2, 2021 00:45
@AaronRobinsonMSFT
Copy link
Member Author

/cc @jkoritzinsky @elinor-fung

hoyosjs
hoyosjs approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the question, it LGTM

noahfalk
noahfalk approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I'm happy whichever way you and Juan decide on the DML

@mikem8361
Copy link
Contributor

mikem8361 commented Jul 2, 2021 via email

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 6296c96 into main Jul 2, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the tracker_memory_update branch July 2, 2021 20:49
@AaronRobinsonMSFT AaronRobinsonMSFT mentioned this pull request Jul 2, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@noahfalk noahfalk noahfalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AaronRobinsonMSFT @mikem8361 @noahfalk @hoyosjs