Skip to content

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Jul 23, 2024

This is necessary so that dotnet/sdk can also downgrade STJ back to 8.0.0. I had to pick 8.0.0 as 8.0.3 isn't available on SBRP.
We can't update to 8.0.4 yet as we don't yet have a VS with S.T.J/8.0.0.4 binding redirects for msbuild on .NET Framework.

This is needed for 9.0 P7. Apparently this doesn't need to be backported as this repo doesn't branch per preview.

cc @rainersigwald @marcpopMSFT @Forgind

This is necessary so that dotnet/sdk can also downgrade back to 8.0.3. We can't update to 8.0.4 yet as we don't yet have a VS with binding redirects for msbuild on .NET Framework.
@ViktorHofer ViktorHofer changed the title Downgrade S.T.J to 8.0.3 Downgrade S.T.J to 8.0.0 Jul 23, 2024
@ViktorHofer ViktorHofer merged commit 1f2704f into main Jul 23, 2024
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch July 23, 2024 14:40
@ViktorHofer
Copy link
Member Author

Argh, the PR got merged because the pipeline is not marked as required. Will submit a fix. Need to get the package into SBRP first.

@marcpopMSFT
Copy link
Member

To summarize the issue, the SDK inserts two components (template locator and the msbuild sdk resolver) into VS. Those components depend on STJ, compile for .NET framework, run in the VS process, and use the STJ from VS. As such, we have to compile against whatever version VS is currently shipping (or older).

This was an issue earlier this year where we updated these two assemblies to depend on version 8.0.2 and then VS would error when creating an aspire project as it couldn't load the template locator package.

Here's the PR where it was fixed previously after we identified the VS block during testing:
dotnet/sdk#39901

@marcpopMSFT
Copy link
Member

(and if non-obvious, those two assemblies depend on the releases assembly so this repo has to align on versions with those two sdk assemblies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants