Skip to content

fix #2628: don't generate parse error when --version is invoked on a root command that has subcommands #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix #2628: don't generate parse error when --version is invoked on a root command that has subcommands #2631

merged 1 commit into from
Jul 16, 2025

Conversation

@jonsequitur
Copy link
Contributor

@jonsequitur jonsequitur commented Jul 15, 2025

This fixes #2628.

@jonsequitur jonsequitur enabled auto-merge (rebase) July 16, 2025 00:02
baronfel
baronfel approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad this was doable!

@jonsequitur jonsequitur merged commit dbc3781 into dotnet:main Jul 16, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--version with sub-commands fails with ParseResult.Errors

2 participants

@jonsequitur @baronfel