-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert log level severity for unknown proxy in ForwardedHeadersMiddleware #64091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the logging severity for unknown proxy IP addresses in ForwardedHeadersMiddleware from Warning back to Debug. The change addresses customer complaints about excessive warning logs that were being generated by legitimate traffic patterns, such as requests from proxies with dynamic IPs or multi-layer proxy scenarios where only the last layer is known to the application.
Key Changes
- Reduced log severity from
WarningtoDebugfor unknown proxy IP addresses - Reverts a previous security-focused change that had unintended consequences in production
Revert logging severity in ForwardedHeaders middleware
Description
As part of strengthening our security posture in the ForwardedHeaders middleware we increased the severity of a log from
DebugtoWarninghoping to give consumers a more obvious signal that unexpected requests were hitting their application.Unfortunately, that change doesn't have the intended effect as it's not uncommon to receive valid requests that have unknown IP addresses in the forwarded headers. e.g. In a proxy scenario where the proxy isn't hosted in a well-defined IP range, or a request goes through many proxy layers and the application is only aware of the last layer, etc.
Customer Impact
Customers are receiving lots of Warning logs, which may trigger telemetry checks, unexpectedly increase log storage size, etc.
Regression?
Change was intended as a signal that unexpected requests were being received, which isn't really accurate in real apps.
Risk
Just changing a log level to what it was before.
Verification
Packaging changes reviewed?