Skip to content

Conversation

MackinnonBuck
Copy link
Member

Fix DragDrop_CanTrigger() flakiness

Applies this change to the release/7.0 branch to fix a flaky test.

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner October 4, 2023 18:32
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Oct 4, 2023
@ghost ghost added this to the 7.0.x milestone Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@MackinnonBuck MackinnonBuck added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 4, 2023
@MackinnonBuck
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/6410072793

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@MackinnonBuck backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update EventTest.cs
Using index info to reconstruct a base tree...
M	src/Components/test/E2ETest/Tests/EventTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Components/test/E2ETest/Tests/EventTest.cs
CONFLICT (content): Merge conflict in src/Components/test/E2ETest/Tests/EventTest.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update EventTest.cs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

@MackinnonBuck an error occurred while backporting to release/6.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@wtgodbe wtgodbe merged commit e3a3257 into release/7.0 Oct 4, 2023
@wtgodbe wtgodbe deleted the mbuck/fix-dragdrop-test-7.0 branch October 4, 2023 20:11
@ghost ghost modified the milestones: 7.0.x, 7.0.12 Oct 4, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 4, 2023
@wtgodbe wtgodbe modified the milestones: 7.0.12, 7.0.13 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants