Docker bound volume mounts resolve to OS local path #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g as windows path (dotnet#993)
ghost
added
the
area-app-model
|
Hmm, we don't have any tests for this code path yet do we... |
|
No, I had noticed that :) |
|
Testing this code is going to be a little awkward in terms of an end to end functional test - but perhaps it can be pulled out into an interna; helper method which we can call from Aspire.Hosting.Tests just to satisfy us that it covers all the various combinations that we could see. |
|
Could you add a test like instead grabbing Container from KubernetesService and check the Spec.VolumeMounts property?
|
joperezr
added
the
community-contribution
|
@r0ss88 are you still interested in updating this? |
|
Apologies for the delayed response, I ended up working round this so no longer require this fix. I'd be happy to add the tests though to cover the change. |
mitchdenny
added this to the
future (would take a change but work not scheduled) milestone
|
Hey @BrennanConroy, I have added the required unit tests as requested. |
BrennanConroy
approved these changes
Jan 22, 2024
|
Thank you @r0ss88 ! |
BrennanConroy
modified the milestones:
future (would take a change but work not scheduled),
preview 3 (Feb)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue when using docker context from WSL mounted path resolving as windows path (#993)