TestShop: Add IsRunMode check for database key #9522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR adds an additional check for run mode before providing a database reset key, addressing the discussed concern in the linked conversation.
- Added a condition to require builder.ExecutionContext.IsRunMode along with development mode.
| @@ -30,7 +30,7 @@ | |||
| var catalogDbApp = builder.AddProject<Projects.CatalogDb>("catalogdbapp") | |||
| .WithReference(catalogDb); | |||
|
|
|||
| if (builder.Environment.IsDevelopment()) | |||
| if (builder.Environment.IsDevelopment() && builder.ExecutionContext.IsRunMode) | |||
There was a problem hiding this comment.
[nitpick] Consider adding a brief comment above this condition explaining why the IsRunMode flag is required along with the IsDevelopment check to aid future maintainers.
Copilot uses AI. Check for mistakes.
davidfowl
approved these changes
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #9503 (comment)