Make RpcResourceState internal in Aspire.Cli and Aspire.Hosting packages #9456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mitchdenny <[email protected]>
Copilot
AI
changed the title
[WIP] Make RpcResourceState internal in Aspire.Cli and Aspire.Hosting packages
Make RpcResourceState internal in Aspire.Cli and Aspire.Hosting packages
May 21, 2025
Copilot finished work on behalf of
mitchdenny
May 21, 2025 23:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tightens the visibility of the RpcResourceState class to internal within both the Aspire.Cli and Aspire.Hosting packages, as it’s only used internally and not part of the public API.
- Changed
RpcResourceStatefrompublictointernalin Aspire.Hosting - Changed
RpcResourceStatefrompublictointernalin Aspire.Cli
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting/Backchannel/RpcResourceState.cs | Made RpcResourceState internal instead of public |
| src/Aspire.Cli/Backchannel/RpcResourceState.cs | Made RpcResourceState internal instead of public |
Comments suppressed due to low confidence (1)
davidfowl
approved these changes
May 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the visibility of the
RpcResourceStateclass from public to internal in both the Aspire.Cli and Aspire.Hosting packages.Changes made:
public class RpcResourceStatetointernal class RpcResourceStateinsrc/Aspire.Cli/Backchannel/RpcResourceState.cspublic class RpcResourceStatetointernal class RpcResourceStateinsrc/Aspire.Hosting/Backchannel/RpcResourceState.csThese are intentionally minimal changes since the class is only used internally within both packages. The changes don't affect any public API behavior, and all tests continue to pass.
Fixes #9455.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)centralus.data.mcr.microsoft.comdotnet publish /home/REDACTED/work/aspire/aspire/tests/testproject/TestProject.ServiceA/TestProject.ServiceA.csproj --configuration Release /t:PublishContainer /p:ContainerRepository=servicea(dns block)dnceng.pkgs.visualstudio.comdotnet publish /home/REDACTED/work/aspire/aspire/tests/testproject/TestProject.ServiceA/TestProject.ServiceA.csproj --configuration Release /t:PublishContainer /p:ContainerRepository=servicea(dns block)pkgs.dev.azure.comdotnet publish /home/REDACTED/work/aspire/aspire/tests/testproject/TestProject.ServiceA/TestProject.ServiceA.csproj --configuration Release /t:PublishContainer /p:ContainerRepository=servicea(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.