Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 17, 2023

Bumps the opentelemetry group with 3 updates: OpenTelemetry.Instrumentation.GrpcNetClient, OpenTelemetry.Instrumentation.Http and OpenTelemetry.Instrumentation.AspNetCore.

Updates OpenTelemetry.Instrumentation.GrpcNetClient from 1.6.0-beta.2 to 1.6.0-beta.3

Release notes

Sourced from OpenTelemetry.Instrumentation.GrpcNetClient's releases.

1.6.0-beta.3 of instrumentation libraries

OpenTelemetry.Instrumentation.AspNetCore

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.server.request.duration metric will be set to _OTHER

    http.request.method is set on http.server.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5001)

  • An additional attribute error.type will be added to activity and http.server.request.duration metric when the request results in unhandled exception. The attribute value will be set to full name of exception type. The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#4986)

  • Fixed network.protocol.version attribute values to match the specification. (#5007)

  • Calls to /metrics will now be included in the http.server.request.duration metric. This change may affect Prometheus pull scenario if the Prometheus server sends request to the scraping endpoint that contains /metrics in path. (#5044)

  • Fixes the http.route attribute for scenarios in which it was previously missing or incorrect. Additionally, the http.route attribute is now the same for both the metric and Activity emitted for a request Lastly, the Activity.DisplayName has been adjusted to have the format {http.request.method} {http.route} to conform with the specification. There remain scenarios when using conventional routing or Razor pages where http.route is still incorrect. See #5056 and #5057 for more details. (#5026)

  • Removed network.protocol.name from http.server.request.duration metric as per spec. (#5049)

OpenTelemetry.Instrumentation.Http

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.client.request.duration metric will be set to _OTHER

    http.request.method is set on http.client.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5003)

  • An additional attribute error.type will be added to activity and http.client.request.duration metric in case of failed requests as per the specification.

    Users moving to net8.0 or newer frameworks from lower versions will see difference in values in case of an exception. net8.0 or newer frameworks add the ability to further drill down the exceptions to a specific type through HttpRequestError enum. For lower versions, the individual types will be rolled in to a single type. This could be a breaking change if alerts are set based on the values.

    The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5005) (#5034)

  • Fixed network.protocol.version attribute values to match the specification. (#5006)

  • Set network.protocol.version value using the protocol version on the received response. If the request fails without response, then network.protocol.version attribute will not be set on Activity and http.client.request.duration metric. (#5043)

OpenTelemetry.Instrumentation.SqlClient

  • Updated Microsoft.Extensions.Configuration and Microsoft.Extensions.Options package version to 8.0.0. (#5051)
Commits
  • 276b307 Update CHANGELOG for 1.6.0-beta.3 release of instrumentation libraries (#5061)
  • 0256f87 Http Span Status - Default to Unset if not in range defined by spec (#5060)
  • 68eabf0 Fix Activity http.route and name (#5026)
  • 2a228f9 Refactor HttpWebRequestActivitySource (#5055)
  • d346196 add concurrency tests with Coyote to CI (#4879)
  • f2c2255 Make MetricPoint reclaim an opt-in experimental feature (#5052)
  • bdd931e Fix histogram for dns.lookup.duration (#5058)
  • e904994 [HttpClient & HttpWebRequest] Set network protocol version from response obje...
  • c337d1e [repo] Misc changes (#5053)
  • b0f9607 Upgrade rc dependencies to net8.0 stable (#5051)
  • Additional commits viewable in compare view

Updates OpenTelemetry.Instrumentation.Http from 1.6.0-beta.2 to 1.6.0-beta.3

Release notes

Sourced from OpenTelemetry.Instrumentation.Http's releases.

1.6.0-beta.3 of instrumentation libraries

OpenTelemetry.Instrumentation.AspNetCore

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.server.request.duration metric will be set to _OTHER

    http.request.method is set on http.server.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5001)

  • An additional attribute error.type will be added to activity and http.server.request.duration metric when the request results in unhandled exception. The attribute value will be set to full name of exception type. The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#4986)

  • Fixed network.protocol.version attribute values to match the specification. (#5007)

  • Calls to /metrics will now be included in the http.server.request.duration metric. This change may affect Prometheus pull scenario if the Prometheus server sends request to the scraping endpoint that contains /metrics in path. (#5044)

  • Fixes the http.route attribute for scenarios in which it was previously missing or incorrect. Additionally, the http.route attribute is now the same for both the metric and Activity emitted for a request Lastly, the Activity.DisplayName has been adjusted to have the format {http.request.method} {http.route} to conform with the specification. There remain scenarios when using conventional routing or Razor pages where http.route is still incorrect. See #5056 and #5057 for more details. (#5026)

  • Removed network.protocol.name from http.server.request.duration metric as per spec. (#5049)

OpenTelemetry.Instrumentation.Http

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.client.request.duration metric will be set to _OTHER

    http.request.method is set on http.client.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5003)

  • An additional attribute error.type will be added to activity and http.client.request.duration metric in case of failed requests as per the specification.

    Users moving to net8.0 or newer frameworks from lower versions will see difference in values in case of an exception. net8.0 or newer frameworks add the ability to further drill down the exceptions to a specific type through HttpRequestError enum. For lower versions, the individual types will be rolled in to a single type. This could be a breaking change if alerts are set based on the values.

    The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5005) (#5034)

  • Fixed network.protocol.version attribute values to match the specification. (#5006)

  • Set network.protocol.version value using the protocol version on the received response. If the request fails without response, then network.protocol.version attribute will not be set on Activity and http.client.request.duration metric. (#5043)

OpenTelemetry.Instrumentation.SqlClient

  • Updated Microsoft.Extensions.Configuration and Microsoft.Extensions.Options package version to 8.0.0. (#5051)
Commits
  • 276b307 Update CHANGELOG for 1.6.0-beta.3 release of instrumentation libraries (#5061)
  • 0256f87 Http Span Status - Default to Unset if not in range defined by spec (#5060)
  • 68eabf0 Fix Activity http.route and name (#5026)
  • 2a228f9 Refactor HttpWebRequestActivitySource (#5055)
  • d346196 add concurrency tests with Coyote to CI (#4879)
  • f2c2255 Make MetricPoint reclaim an opt-in experimental feature (#5052)
  • bdd931e Fix histogram for dns.lookup.duration (#5058)
  • e904994 [HttpClient & HttpWebRequest] Set network protocol version from response obje...
  • c337d1e [repo] Misc changes (#5053)
  • b0f9607 Upgrade rc dependencies to net8.0 stable (#5051)
  • Additional commits viewable in compare view

Updates OpenTelemetry.Instrumentation.AspNetCore from 1.6.0-beta.2 to 1.6.0-beta.3

Release notes

Sourced from OpenTelemetry.Instrumentation.AspNetCore's releases.

1.6.0-beta.3 of instrumentation libraries

OpenTelemetry.Instrumentation.AspNetCore

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.server.request.duration metric will be set to _OTHER

    http.request.method is set on http.server.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5001)

  • An additional attribute error.type will be added to activity and http.server.request.duration metric when the request results in unhandled exception. The attribute value will be set to full name of exception type. The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#4986)

  • Fixed network.protocol.version attribute values to match the specification. (#5007)

  • Calls to /metrics will now be included in the http.server.request.duration metric. This change may affect Prometheus pull scenario if the Prometheus server sends request to the scraping endpoint that contains /metrics in path. (#5044)

  • Fixes the http.route attribute for scenarios in which it was previously missing or incorrect. Additionally, the http.route attribute is now the same for both the metric and Activity emitted for a request Lastly, the Activity.DisplayName has been adjusted to have the format {http.request.method} {http.route} to conform with the specification. There remain scenarios when using conventional routing or Razor pages where http.route is still incorrect. See #5056 and #5057 for more details. (#5026)

  • Removed network.protocol.name from http.server.request.duration metric as per spec. (#5049)

OpenTelemetry.Instrumentation.Http

  • Removed the Activity Status Description that was being set during exceptions. Activity Status will continue to be reported as Error. This is a breaking change. EnrichWithException can be leveraged to restore this behavior. (#5025)

  • Updated http.request.method to match specification guidelines.

    • For activity, if the method does not belong to one of the known values then the request method will be set on an additional tag http.request.method.original and http.request.method will be set to _OTHER.
    • For metrics, if the original method does not belong to one of the known values then http.request.method on http.client.request.duration metric will be set to _OTHER

    http.request.method is set on http.client.request.duration metric or activity when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5003)

  • An additional attribute error.type will be added to activity and http.client.request.duration metric in case of failed requests as per the specification.

    Users moving to net8.0 or newer frameworks from lower versions will see difference in values in case of an exception. net8.0 or newer frameworks add the ability to further drill down the exceptions to a specific type through HttpRequestError enum. For lower versions, the individual types will be rolled in to a single type. This could be a breaking change if alerts are set based on the values.

    The attribute will only be added when OTEL_SEMCONV_STABILITY_OPT_IN environment variable is set to http or http/dup. (#5005) (#5034)

  • Fixed network.protocol.version attribute values to match the specification. (#5006)

  • Set network.protocol.version value using the protocol version on the received response. If the request fails without response, then network.protocol.version attribute will not be set on Activity and http.client.request.duration metric. (#5043)

OpenTelemetry.Instrumentation.SqlClient

  • Updated Microsoft.Extensions.Configuration and Microsoft.Extensions.Options package version to 8.0.0. (#5051)
Commits
  • 276b307 Update CHANGELOG for 1.6.0-beta.3 release of instrumentation libraries (#5061)
  • 0256f87 Http Span Status - Default to Unset if not in range defined by spec (#5060)
  • 68eabf0 Fix Activity http.route and name (#5026)
  • 2a228f9 Refactor HttpWebRequestActivitySource (#5055)
  • d346196 add concurrency tests with Coyote to CI (#4879)
  • f2c2255 Make MetricPoint reclaim an opt-in experimental feature (#5052)
  • bdd931e Fix histogram for dns.lookup.duration (#5058)
  • e904994 [HttpClient & HttpWebRequest] Set network protocol version from response obje...
  • c337d1e [repo] Misc changes (#5053)
  • b0f9607 Upgrade rc dependencies to net8.0 stable (#5051)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 17, 2023
@danmoseley danmoseley enabled auto-merge (squash) November 17, 2023 23:46
@davidfowl
Copy link
Member

Does this automate the mirror

@danmoseley
Copy link
Member

No, and if it did I'm not certain whether that would be consistent with the purpose of the mirror.

We don't need to merge these each time or promptly. Only if we need a fix or want to stabilize.

Bumps the opentelemetry group with 3 updates: [OpenTelemetry.Instrumentation.GrpcNetClient](https://github.com/open-telemetry/opentelemetry-dotnet), [OpenTelemetry.Instrumentation.Http](https://github.com/open-telemetry/opentelemetry-dotnet) and [OpenTelemetry.Instrumentation.AspNetCore](https://github.com/open-telemetry/opentelemetry-dotnet).


Updates `OpenTelemetry.Instrumentation.GrpcNetClient` from 1.6.0-beta.2 to 1.6.0-beta.3
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@1.6.0-beta.2...1.6.0-beta.3)

Updates `OpenTelemetry.Instrumentation.Http` from 1.6.0-beta.2 to 1.6.0-beta.3
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@1.6.0-beta.2...1.6.0-beta.3)

Updates `OpenTelemetry.Instrumentation.AspNetCore` from 1.6.0-beta.2 to 1.6.0-beta.3
- [Release notes](https://github.com/open-telemetry/opentelemetry-dotnet/releases)
- [Commits](open-telemetry/opentelemetry-dotnet@1.6.0-beta.2...1.6.0-beta.3)

---
updated-dependencies:
- dependency-name: OpenTelemetry.Instrumentation.GrpcNetClient
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
- dependency-name: OpenTelemetry.Instrumentation.Http
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
- dependency-name: OpenTelemetry.Instrumentation.AspNetCore
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: opentelemetry
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/nuget/opentelemetry-7b8e4cc618 branch from d5fd713 to 71cdc48 Compare November 20, 2023 15:29
@danmoseley
Copy link
Member

BTW, if you want to mirror something, instructions are https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md
it takes about 10 mins

@danmoseley danmoseley closed this Nov 20, 2023
auto-merge was automatically disabled November 20, 2023 16:36

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 20, 2023

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

@danmoseley danmoseley reopened this Nov 20, 2023
@danmoseley danmoseley enabled auto-merge (squash) November 20, 2023 16:36
@danmoseley danmoseley merged commit eceed4d into main Nov 20, 2023
@danmoseley danmoseley deleted the dependabot/nuget/opentelemetry-7b8e4cc618 branch November 20, 2023 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants