Skip to content

Fix failure in MongoDbFunctionalTests.VerifyWithInitFiles #9391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

danegsta
Copy link
Member

@danegsta danegsta commented May 19, 2025

Description

Fix test failure due to a temp folder not being created before config files were written to it.

Fixes #5937

@Copilot Copilot AI review requested due to automatic review settings May 19, 2025 17:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a test failure in MongoDbFunctionalTests.VerifyWithInitFiles by ensuring that the temp directory is created before configuration files are written.

  • Added Directory.CreateDirectory(initFilesPath) to create the temporary folder.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 19, 2025
@danegsta danegsta requested a review from radical May 19, 2025 17:05
@danegsta danegsta self-assigned this May 19, 2025
@danmoseley danmoseley merged commit 9353f7e into dotnet:main May 19, 2025
499 of 503 checks passed
@danmoseley
Copy link
Member

oh whoops @danegsta I guess we should remove [QuarantinedTest("https://github.com/dotnet/aspire/issues/5937")] at the same time.

@danegsta
Copy link
Member Author

oh whoops @danegsta I guess we should remove [QuarantinedTest("https://github.com/dotnet/aspire/issues/5937")] at the same time.

I'll open a new PR!

@danegsta
Copy link
Member Author

@danmoseley #9402

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure: Aspire.Hosting.MongoDB.Tests.MongoDbFunctionalTests.VerifyWithInitFiles
3 participants