-
Notifications
You must be signed in to change notification settings - Fork 672
Do not fail on partial trust warning. #9384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
tests/Aspire.Cli.Tests/Certificates/CertificateServiceTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using Aspire.Cli.Certificates; | ||
using Aspire.Cli.Tests.TestServices; | ||
using Aspire.Cli.Tests.Utils; | ||
using Microsoft.Extensions.DependencyInjection; | ||
using Xunit; | ||
|
||
namespace Aspire.Cli.Tests.Certificates; | ||
|
||
public class CertificateServiceTests(ITestOutputHelper outputHelper) | ||
{ | ||
[Fact] | ||
public async Task EnsureCertificatesTrustedAsyncSucceedsOnExitCode4IfPartialTrustMessageDetected() | ||
{ | ||
var services = CliTestHelper.CreateServiceCollection(outputHelper, options => | ||
{ | ||
options.DotNetCliRunnerFactory = sp => | ||
{ | ||
var runner = new TestDotNetCliRunner(); | ||
runner.CheckHttpCertificateAsyncCallback = (_, _) => 1; | ||
runner.TrustHttpCertificateAsyncCallback = (options, _) => | ||
{ | ||
Assert.NotNull(options.StandardErrorCallback); | ||
options.StandardErrorCallback!.Invoke("There was an error trusting the HTTPS developer certificate. It will be trusted by some clients but not by others."); | ||
mitchdenny marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return 4; | ||
}; | ||
return runner; | ||
}; | ||
}); | ||
|
||
var sp = services.BuildServiceProvider(); | ||
var cs = sp.GetRequiredService<ICertificateService>(); | ||
var runner = sp.GetRequiredService<IDotNetCliRunner>(); | ||
|
||
// If this does not throw then the code is behaving correctly. | ||
await cs.EnsureCertificatesTrustedAsync(runner, TestContext.Current.CancellationToken).WaitAsync(CliTestConstants.DefaultTimeout); | ||
} | ||
|
||
[Fact] | ||
public async Task EnsureCertificatesTrustedAsyncFailsOnExitCode4IfPartialTrustMessageNotDetected() | ||
{ | ||
var services = CliTestHelper.CreateServiceCollection(outputHelper, options => | ||
{ | ||
options.DotNetCliRunnerFactory = sp => | ||
{ | ||
var runner = new TestDotNetCliRunner(); | ||
runner.CheckHttpCertificateAsyncCallback = (_, _) => 1; | ||
runner.TrustHttpCertificateAsyncCallback = (options, _) => 4; | ||
return runner; | ||
}; | ||
}); | ||
|
||
var sp = services.BuildServiceProvider(); | ||
var cs = sp.GetRequiredService<ICertificateService>(); | ||
var runner = sp.GetRequiredService<IDotNetCliRunner>(); | ||
|
||
var ex = await Assert.ThrowsAsync<CertificateServiceException>(async () => | ||
{ | ||
await cs.EnsureCertificatesTrustedAsync(runner, TestContext.Current.CancellationToken).WaitAsync(CliTestConstants.DefaultTimeout); | ||
|
||
}); | ||
|
||
Assert.Equal("Failed to trust certificates, trust command failed with exit code: 4", ex.Message); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.