Skip to content

Minor improvements to resource changed log #9303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented May 14, 2025

Description

  • Remove extra braces around IsHidden
  • Move IsHidden next to state
  • Make commands consistent with other name values by making name come first

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK requested review from mitchdenny, adamint and Copilot May 14, 2025 08:40
@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label May 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes minor improvements to the resource change log by removing duplicate logging of the IsHidden property and adjusting the order of fields to be consistent with other parts of the application.

  • Removed duplicate braces for IsHidden in the log message.
  • Moved the IsHidden log parameter next to the state details.
  • Reordered command details to list the name before its display name.

@JamesNK JamesNK merged commit 4b5871c into main May 14, 2025
177 checks passed
@JamesNK JamesNK deleted the jamesnk/minor-log-improvement branch May 14, 2025 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants