API review: WithHostPort should accept null for port param
#9282
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API for the WithHostPort extension methods in both the SQL Server and Redis hosting builders to allow a null value for the port parameter, enabling random port assignment.
- Update WithHostPort signature to accept nullable integer (int? port) in SqlServerBuilderExtensions.cs.
- Update WithHostPort signature to accept nullable integer (int? port) in RedisBuilderExtensions.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Hosting.SqlServer/SqlServerBuilderExtensions.cs | Updated WithHostPort parameter from int to int? to allow null port. |
| src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs | Updated WithHostPort parameter from int to int? to allow null port. |
github-actions
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
community-contribution
|
Don't forget to backport. |
|
/backport to release/9.3 |
|
Started backporting to release/9.3: https://github.com/dotnet/aspire/actions/runs/15001384937 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from API review: #8736 (comment)