Skip to content

Changing default SKU for App Service Plan to P0V3 #9280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Changing default SKU for App Service Plan to P0V3 #9280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fb3fa7
Changing default SKU for App Service Plan to P0V3
ShilpiRachna1 May 13, 2025
219ec08
Removed TargetPort property from sitecontainer definition
ShilpiRachna1 May 13, 2025
7fc2f16
Updated manifest file for sample appservice project
ShilpiRachna1 May 14, 2025
09ca3c6
Updated the comments related to sidecar configuration
ShilpiRachna1 May 14, 2025
d2a0830
Fixed failing AppService unit tests
ShilpiRachna1 May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ public static IResourceBuilder<AzureAppServiceEnvironmentResource> AddAzureAppSe
{
Sku = new AppServiceSkuDescription
{
Name = "B1",
Tier = "Basic"
Name = "P0V3",
Tier = "Premium"
Comment on lines +87 to +88
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having second thoughts about this one.

},
Kind = "Linux",
IsReserved = true
Expand Down
14 changes: 13 additions & 1 deletion src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public void BuildWebSite(AzureResourceInfrastructure infra)
AppServicePlanId = appServicePlanParameter,
SiteConfig = new SiteConfigProperties()
{
LinuxFxVersion = BicepFunction.Interpolate($"DOCKER|{containerImage}"),
LinuxFxVersion = "SITECONTAINERS",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused by this change. Why do we need sidecars? Or is this just the new way of using containers?

Copy link

@btardif btardif May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is what we want to do going fwd instead of overloading the linuxFX version. There is no sidecar being configured here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the port hardcoded to 8080?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed setting the port as it is inferred by the platform. Validated with the changes in fork code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this need to be set to the internal port of the http endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When TargetPort is not specified, our container orchestrator can infer the exposed PORT in the container image and use it for serving the http traffic. So, explicitly mentioning TargetPort is not required.

AcrUserManagedIdentityId = acrClientIdParameter,
UseManagedIdentityCreds = true,
AppSettings = []
Expand All @@ -226,6 +226,18 @@ public void BuildWebSite(AzureResourceInfrastructure infra)
},
};

var mainContainer = new SiteContainer("mainContainer")
{
Parent = webSite,
Name = "main",
Image = containerImage,
AuthType = SiteContainerAuthType.UserAssigned,
UserManagedIdentityClientId = acrClientIdParameter,
IsMain = true
};

infra.Add(mainContainer);

foreach (var kv in EnvironmentVariables)
{
var (val, secretType) = ProcessValue(kv.Value);
Expand Down
Loading