Skip to content

Update health check to ensure blob containers created at right time #9159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 16, 2025
Merged

Update health check to ensure blob containers created at right time #9159

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4ba607c
Update health check to ensure blob containers created at right time
RussKie May 8, 2025
ec3a2df
fixup! Update health check to ensure blob containers created at right…
RussKie May 13, 2025
6aa390f
fixup! Update health check to ensure blob containers created at right…
RussKie May 13, 2025
e993433
fixup! Update health check to ensure blob containers created at right…
RussKie May 13, 2025
eddebef
Prevent multiple container checks
sebastienros May 13, 2025
5bd0c61
Use better variable name
sebastienros May 13, 2025
48e2d5d
Move container creation to RunAsEmulator
sebastienros May 13, 2025
9737260
Register single hc for blobs
sebastienros May 13, 2025
80ce587
Reuse blobserviceclient
sebastienros May 13, 2025
4ebf0d7
Fix registrations
sebastienros May 13, 2025
a72f514
Remove custom heathcheck
sebastienros May 13, 2025
c21f230
Remove custom healthcheck
sebastienros May 13, 2025
53fac90
Remove specific health checks
sebastienros May 14, 2025
3242c5c
Add blob and container health checks
sebastienros May 14, 2025
ba67f13
Fix test
sebastienros May 14, 2025
273233b
Feedback
sebastienros May 15, 2025
30641bd
Improve comment
sebastienros May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1503,6 +1503,10 @@ public async Task AddAzureStorageViaPublishMode()
};
});

var blob = storage.AddBlobs("blob");
var queue = storage.AddQueues("queue");
var table = storage.AddTables("table");

storage.Resource.Outputs["blobEndpoint"] = "https://myblob";
storage.Resource.Outputs["queueEndpoint"] = "https://myqueue";
storage.Resource.Outputs["tableEndpoint"] = "https://mytable";
Expand Down Expand Up @@ -1578,7 +1582,6 @@ param principalId string
Assert.Equal(expectedBicep, storageRolesManifest.BicepText);

// Check blob resource.
var blob = storage.AddBlobs("blob");

var connectionStringBlobResource = (IResourceWithConnectionString)blob.Resource;

Expand All @@ -1593,8 +1596,6 @@ param principalId string
Assert.Equal(expectedBlobManifest, blobManifest.ToString());

// Check queue resource.
var queue = storage.AddQueues("queue");

var connectionStringQueueResource = (IResourceWithConnectionString)queue.Resource;

Assert.Equal("https://myqueue", await connectionStringQueueResource.GetConnectionStringAsync());
Expand All @@ -1608,8 +1609,6 @@ param principalId string
Assert.Equal(expectedQueueManifest, queueManifest.ToString());

// Check table resource.
var table = storage.AddTables("table");

var connectionStringTableResource = (IResourceWithConnectionString)table.Resource;

Assert.Equal("https://mytable", await connectionStringTableResource.GetConnectionStringAsync());
Expand Down