Skip to content

Fixed resolving secrets for keyvault references in run mode #8751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

Fixed resolving secrets for keyvault references in run mode #8751

merged 1 commit into from
Apr 13, 2025

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Apr 13, 2025 •
edited
Loading

Description

  • Moved token credential resolution out of the AzureProvisioner so it can shared.
  • Configure the secret resolving in both configure and provision cases.

Fixes #8750

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No (Manual coverage to keep the change small in an attempt to patch in 9.2.x)
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    template=02-docs-request.yml)):
    • No

@davidfowl
Fixed resolving secrets for keyvault refernces in run mode
a6bb6f2 
- Moved token credential resolution out of the AzureProvisioner so it can shared.
- Configure the secret resolving in both configure and provision cases.
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 13, 2025
@mitchdenny
Copy link
Member

Looks good. Should we be hotfixing this?

@davidfowl
Copy link
Member Author

Yep

@davidfowl davidfowl changed the title Fixed resolving secrets for keyvault refernces in run mode Fixed resolving secrets for keyvault references in run mode Apr 13, 2025
@onionhammer
Copy link
Contributor

Legend

@davidfowl davidfowl merged commit 9918f8b into main Apr 13, 2025
175 checks passed
@davidfowl davidfowl deleted the davidfowl/fix-kv branch April 13, 2025 15:00
@davidfowl
Copy link
Member Author

/backport to release/9.2

@github-actions
Copy link
Contributor

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14430623244

@github-actions github-actions bot mentioned this pull request Apr 13, 2025
Merged
@eerhardt eerhardt mentioned this pull request Apr 21, 2025
Closed
1 task
@davidfowl davidfowl mentioned this pull request Apr 28, 2025
Merged
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

Assignees

No one assigned

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear how to create custom bicep resources which generate secrets

3 participants

@davidfowl @mitchdenny @onionhammer