Skip to content

Make IPublishingActivityProgressReporter mockable #8697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2025
Merged

Make IPublishingActivityProgressReporter mockable #8697

merged 4 commits into from
Apr 14, 2025

Conversation

eerhardt
Copy link
Member

Trying to test components that need an IPublishingActivityProgressReporter isn't currently possible without reflection.

Also add a Null reporter to easily use in tests. Just like NullLogger.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

eerhardt added 2 commits April 10, 2025 11:45
@eerhardt
Make IPublishingActivityProgressReporter mockable
512a56c 
Also add a Null reporter to easily use in tests.
@eerhardt
Add test
5fe1ffa
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 10, 2025
Copilot
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@eerhardt eerhardt added area-deployment and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 10, 2025
@davidfowl davidfowl merged commit 978cce6 into dotnet:main Apr 14, 2025
174 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@davidfowl davidfowl davidfowl approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia

Assignees
No one assigned
Labels
area-deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @davidfowl