Skip to content

[tests] Skip generating Directory.Packages.Versions.props for Test #8621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

radical
Copy link
Member

@radical radical commented Apr 8, 2025

.. Utility projects.

@Copilot Copilot AI review requested due to automatic review settings April 8, 2025 08:11
@radical radical requested a review from eerhardt as a code owner April 8, 2025 08:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • tests/Shared/RepoTesting/Aspire.RepoTesting.targets: Language not supported

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 8, 2025
@radical radical added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-integrations Issues pertaining to Aspire Integrations packages labels Apr 8, 2025
@danmoseley
Copy link
Member

2025-04-08T08:19:23.5783182Z  [test-xunit.net] [xUnit.net 00:00:21.21]     starter_test.Debug_xunit_net_rkwvp5qq_jdq.Tests.WebTests.GetWebResourceRootReturnsOkStatusCode [FAIL]
2025-04-08T08:19:23.5784037Z  [test-xunit.net]   Failed starter_test.Debug_xunit_net_rkwvp5qq_jdq.Tests.WebTests.GetWebResourceRootReturnsOkStatusCode [20 s]
2025-04-08T08:19:23.5784587Z  [test-xunit.net]   Error Message:
2025-04-08T08:19:23.5785334Z  [test-xunit.net]    Aspire.Hosting.DistributedApplicationException : Stopped waiting for resource 'webfrontend' to become healthy because it failed to start.
2025-04-08T08:19:23.5785973Z  [test-xunit.net]   Stack Trace:
2025-04-08T08:19:23.5787109Z  [test-xunit.net]      at Aspire.Hosting.ApplicationModel.ResourceNotificationService.WaitForResourceHealthyAsync(String resourceName, WaitBehavior waitBehavior, CancellationToken cancellationToken) in /_/src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs:line 282
2025-04-08T08:19:23.5789265Z  [test-xunit.net]    at Aspire.Hosting.ApplicationModel.ResourceNotificationService.WaitForResourceHealthyAsync(String resourceName, CancellationToken cancellationToken) in /_/src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs:line 243
2025-04-08T08:19:23.5791022Z  [test-xunit.net]    at starter_test.Debug_xunit_net_rkwvp5qq_jdq.Tests.WebTests.GetWebResourceRootReturnsOkStatusCode() in /tmp/templates-testroot/starter test.Debug-xunit_net_rkwvp5qq_jdq/starter test.Debug-xunit_net_rkwvp5qq_jdq.Tests/WebTests.cs:line 34
2025-04-08T08:19:23.5792824Z  [test-xunit.net]    at starter_test.Debug_xunit_net_rkwvp5qq_jdq.Tests.WebTests.GetWebResourceRootReturnsOkStatusCode() in /tmp/templates-testroot/starter test.Debug-xunit_net_rkwvp5qq_jdq/starter test.Debug-xunit_net_rkwvp5qq_jdq.Tests/WebTests.cs:line 38
2025-04-08T08:19:23.5793863Z  [test-xunit.net] --- End of stack trace from previous location ---
2025-04-08T08:19:23.5794186Z  [test-xunit.net] 
2025-04-08T08:19:23.5794675Z  [test-xunit.net] Failed!  - Failed:     1, Passed:     0, Skipped:     0, Total:     1, Duration: 20 s - starter test.Debug-xunit_net_rkwvp5qq_jdq.Tests.dll (net9.0)
2025-04-08T08:19:23.5795300Z  [test-xunit.net] Got the Exited event, and waiting on WaitForExitAsync now
2025-04-08T08:19:23.5795668Z  [test-xunit.net] Process ran for 27.7857603 secs

#8649

@danmoseley danmoseley enabled auto-merge (squash) April 8, 2025 20:48
@danmoseley danmoseley merged commit 30e0126 into dotnet:main Apr 8, 2025
176 checks passed
radical added a commit that referenced this pull request Apr 9, 2025
Youssef1313 added a commit that referenced this pull request Apr 9, 2025
* Migrate from VSTest to Microsoft.Testing.Platform

* Address TODO

* Cleanup stuff around runsettings

* Add comment

* Progress

* Remove locale

* Always show live output

* Restore test session timeout

* Fix timeout

* Fix typo

* Fix duplicate commnand-line options

* Fix Linux

* Fix for Linux

* Fix

* Fix

* Filter failing

* Fix

* ignore exit code 8

* Fix extra dot

* Ignore exit code

* Fix duplicate --ignore-exit-code

* Fix playground tests on helix

* Move to RepoTesting.props

* Fix results dir

* Fix

* Progress

* Fix duplicate command-line option

* Missing report-trx

* Run executable

* Address review comments

* Revert "Run executable"

This reverts commit d10e168.

* dotnet dll

* Introduce version selector for Aspire templates (#8625)

* Introduce version selecto to aspire new

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <[email protected]>

* Update src/Aspire.Cli/Commands/NewCommand.cs

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: David Fowler <[email protected]>
Co-authored-by: Copilot <[email protected]>

* Error handling for GetCapabilitiesAsync connection issues (#8614)

* Error out when GetCapabiltiesAsync is missing or unexpected exception occurs.

* Update src/Aspire.Cli/DotNetCliRunner.cs

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

* Obsolete AddAzureContainerAppsInfrastructure (#8639)

* Obsolete AddAzureContainerAppsInfrastructure

This method is no longer meant to be used. Instead developers should be calling AddAzureContainerAppEnvironment.

Covert the tests using this API to the new API

* Fix volume output naming issue

We weren't discriminating between volumes and bindmounts, which caused a cache collision.

* Switch the prefix at the beginning

* Add error handling for package updates in workflow (#8390)

* Filter out tracing health endpoints in service defaults templates (#8643)

* Filter out tracing health endpoints

Fixes #8580

* Fix typo

* Show neutral icon for container exiting with status code 0 (#8477)

* Show neutral icon for container exiting with status code 0

* Show info/stop icons for all exited resources with status code 0

* Add finished test for custom resource, remove exit code expectation

* update tests

* [tests] Correctly mark Aspire.Dashboard.Tests.Integration.Playwright.AppBarTests with RequiresPlaywright (#8647)

* [tests] Skip generating Directory.Packages.Versions.props for Test (#8621)

.. Utility projects.

* Fix running playground tests on windows

---------

Co-authored-by: Ankit Jain <[email protected]>
Co-authored-by: Dan Moseley <[email protected]>
Co-authored-by: Mitch Denny <[email protected]>
Co-authored-by: David Fowler <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Jose Perez Rodriguez <[email protected]>
Co-authored-by: Damian Edwards <[email protected]>
Co-authored-by: Adam Ratzman <[email protected]>
@radical radical deleted the test-commons-skip-package branch April 9, 2025 20:15
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants