Skip to content

[tests] Re-enable some quarantined tests that haven't been failing #8615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

[tests] Re-enable some quarantined tests that haven't been failing #8615

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82604bd
[tests] Re-enable some quarantined tests that haven't been failing
radical Apr 8, 2025
072c8a9
fix build
radical Apr 8, 2025
36b583c
Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests
radical Apr 8, 2025
71917c1
Aspire.Hosting.Tests is taking longer than 10mins to run. Bump the se…
radical Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ await AsyncTestHelpers.AssertIsTrueRetryAsync(
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7943")]
public async Task AppBar_Change_Theme_ReloadPage()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Hosting.Testing.Tests/TestingBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ public async Task GetHttpClientBeforeStart(bool genericEntryPoint)
[InlineData(false, true)]
[InlineData(true, false)]
[InlineData(true, true)]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7930")]
public async Task ArgsPropagateToAppHostConfiguration(bool genericEntryPoint, bool directArgs)
{
string[] args = directArgs ? ["APP_HOST_ARG=42"] : [];
Expand Down
17 changes: 0 additions & 17 deletions tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ public void TryAddWillNotAddTheSameLifecycleHook()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task AllocatedPortsAssignedAfterHookRuns()
{
using var testProgram = CreateTestProgram("ports-assigned-after-hook-runs");
Expand Down Expand Up @@ -344,7 +343,6 @@ public Task AfterEndpointsAllocatedAsync(DistributedApplicationModel appModel, C
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task TestServicesWithMultipleReplicas()
{
var replicaCount = 3;
Expand Down Expand Up @@ -401,7 +399,6 @@ public async Task TestServicesWithMultipleReplicas()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyContainerArgs()
{
using var testProgram = CreateTestProgram("verify-container-args");
Expand Down Expand Up @@ -486,7 +483,6 @@ public async Task VerifyContainerCreateFile()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyContainerStopStartWorks()
{
using var testProgram = CreateTestProgram("container-start-stop", randomizePorts: false);
Expand Down Expand Up @@ -574,7 +570,6 @@ public async Task VerifyExecutableStopStartWorks()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task SpecifyingEnvPortInEndpointFlowsToEnv()
{
const string testName = "ports-flow-to-env";
Expand Down Expand Up @@ -631,7 +626,6 @@ public async Task SpecifyingEnvPortInEndpointFlowsToEnv()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task StartAsync_DashboardAuthConfig_PassedToDashboardProcess()
{
const string testName = "dashboard-auth-config";
Expand Down Expand Up @@ -709,7 +703,6 @@ public async Task StartAsync_UnsecuredAllowAnonymous_PassedToDashboardProcess()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyDockerWithEntrypointWorks()
{
const string testName = "docker-entrypoint";
Expand Down Expand Up @@ -738,7 +731,6 @@ public async Task VerifyDockerWithEntrypointWorks()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyDockerWithBindMountWorksWithAbsolutePaths()
{
const string testName = "docker-bindmount-absolute";
Expand Down Expand Up @@ -769,7 +761,6 @@ public async Task VerifyDockerWithBindMountWorksWithAbsolutePaths()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyDockerWithBindMountWorksWithRelativePaths()
{
const string testName = "docker-bindmount-relative";
Expand Down Expand Up @@ -800,7 +791,6 @@ public async Task VerifyDockerWithBindMountWorksWithRelativePaths()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task VerifyDockerWithVolumeWorksWithName()
{
const string testName = "docker-volume";
Expand Down Expand Up @@ -830,7 +820,6 @@ public async Task VerifyDockerWithVolumeWorksWithName()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task KubernetesHasResourceNameForContainersAndExes()
{
const string testName = "kube-resource-names";
Expand Down Expand Up @@ -888,7 +877,6 @@ public async Task KubernetesHasResourceNameForContainersAndExes()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task ReplicasAndProxylessEndpointThrows()
{
const string testName = "replicas-no-proxyless-endpoints";
Expand All @@ -907,7 +895,6 @@ public async Task ReplicasAndProxylessEndpointThrows()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task ProxylessEndpointWithoutPortThrows()
{
const string testName = "proxyess-endpoint-without-port";
Expand All @@ -927,7 +914,6 @@ public async Task ProxylessEndpointWithoutPortThrows()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task ProxylessEndpointWorks()
{
const string testName = "proxyless-endpoint-works";
Expand Down Expand Up @@ -1031,7 +1017,6 @@ public async Task ProxylessAndProxiedEndpointBothWorkOnSameResource()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task ProxylessContainerCanBeReferenced()
{
const string testName = "proxyless-container";
Expand Down Expand Up @@ -1137,7 +1122,6 @@ public async Task WithEndpointProxySupportDisablesProxies()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task ProxylessContainerWithoutPortThrows()
{
const string testName = "proxyless-container-without-ports";
Expand All @@ -1156,7 +1140,6 @@ public async Task ProxylessContainerWithoutPortThrows()

[Fact]
[RequiresDocker]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/4651")]
public async Task AfterResourcesCreatedLifecycleHookWorks()
{
const string testName = "lifecycle-hook-after-resource-created";
Expand Down
3 changes: 0 additions & 3 deletions tests/Aspire.Hosting.Tests/Health/ResourceHealthCheckServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System.Threading.Channels;
using Aspire.Hosting.Health;
using Aspire.Hosting.Utils;
using Aspire.TestUtilities;
using Microsoft.AspNetCore.InternalTesting;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Diagnostics.HealthChecks;
Expand Down Expand Up @@ -97,7 +96,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8326")]
public async Task ResourcesWithHealthCheck_CreationErrorIsReported()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -138,7 +136,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8103")]
public async Task ResourcesWithHealthCheck_StopsAndRestartsMonitoringWithResource()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Hosting.Tests/OperationModesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Aspire.Hosting.Tests;
public class OperationModesTests(ITestOutputHelper outputHelper)
{
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8400")]
public async Task VerifyBackwardsCompatableRunModeInvocation()
{
// The purpose of this test is to verify that the apphost executable will continue
Expand Down
4 changes: 0 additions & 4 deletions tests/Aspire.Hosting.Tests/SlimTestProgramTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Aspire.TestUtilities;
using Aspire.Hosting.Testing.Tests;
using Microsoft.AspNetCore.InternalTesting;
using Xunit;
Expand All @@ -19,7 +18,6 @@ public SlimTestProgramTests(SlimTestProgramFixture slimTestProgramFixture)
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestProjectStartsAndStopsCleanly()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand All @@ -44,7 +42,6 @@ private static async Task EnsureServicesAreRunning(TestProgram testProgram, Canc
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand All @@ -63,7 +60,6 @@ public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatc
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand Down
3 changes: 0 additions & 3 deletions tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ public async Task WithHttpCommand_ResultsInExpectedResultForStatusCode(int statu
[InlineData("get", true)]
[InlineData("post", false)]
[Theory]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8514")]
public async Task WithHttpCommand_ResultsInExpectedResultForHttpMethod(string? httpMethod, bool expectSuccess)
{
// Arrange
Expand Down Expand Up @@ -263,7 +262,6 @@ public async Task WithHttpCommand_UsesEndpointSelector()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8192")]
public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequest()
{
// Arrange
Expand Down Expand Up @@ -308,7 +306,6 @@ public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingReque
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8200")]
public async Task WithHttpCommand_CallsGetResponseCallback_AfterSendingRequest()
{
// Arrange
Expand Down
Loading