Skip to content

Fix NuGet Package Icons #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix NuGet Package Icons #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
<LangVersion>preview</LangVersion>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<SharedDir>$(MSBuildThisFileDirectory)/src/Shared/</SharedDir>
<!-- Capture PackageIconFullPath into DefaultDotnetIconFullPath before we overwrite PackageIconFullPath. -->
<!-- DefaultDotnetIconFullPath is only needed for the ServiceDisovery packages. The property can be removed when these libraries move. See https://github.com/dotnet/aspire/issues/170 -->
<DefaultDotnetIconFullPath>$(PackageIconFullPath)</DefaultDotnetIconFullPath>
<PackageIconFullPath>$(SharedDir)Aspire_icon_256.png</PackageIconFullPath>
<WarnOnPackingNonPackableProject>false</WarnOnPackingNonPackableProject>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
Expand Down
2 changes: 0 additions & 2 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
<ReadMePath>$(MSBuildProjectDirectory)\README.md</ReadMePath>
<ReadMeExists Condition="Exists('$(ReadMePath)')">true</ReadMeExists>
<PackageReadmeFile Condition="'$(PackageReadmeFile)' == '' And '$(ReadMeExists)' == 'true'">README.md</PackageReadmeFile>

<PackageIconFullPath Condition="'$(SuppressAspireIcon)' != 'true'">$(SharedDir)Aspire_icon_256.png</PackageIconFullPath>
</PropertyGroup>

<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...s.ServiceDiscovery.Abstractions/Microsoft.Extensions.ServiceDiscovery.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<IsPackable>true</IsPackable>
<IsAotCompatible>true</IsAotCompatible>
<Description>Provides abstractions for service discovery. Interfaces defined in this package are implemented in Microsoft.Extensions.ServiceDiscovery and other service discovery packages.</Description>
<SuppressAspireIcon>true</SuppressAspireIcon>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...icrosoft.Extensions.ServiceDiscovery.Dns/Microsoft.Extensions.ServiceDiscovery.Dns.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<IsPackable>true</IsPackable>
<IsAotCompatible>true</IsAotCompatible>
<Description>Provides extensions to HttpClient to resolve well-known hostnames to concrete endpoints based on DNS records. Useful for service resolution in orchestrators such as Kubernetes.</Description>
<SuppressAspireIcon>true</SuppressAspireIcon>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...rosoft.Extensions.ServiceDiscovery.Yarp/Microsoft.Extensions.ServiceDiscovery.Yarp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<IsPackable>true</IsPackable>
<IsAotCompatible>true</IsAotCompatible>
<Description>Provides extensions for service discovery for the YARP reverse proxy.</Description>
<SuppressAspireIcon>true</SuppressAspireIcon>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<IsPackable>true</IsPackable>
<IsAotCompatible>true</IsAotCompatible>
<Description>Provides extensions to HttpClient that enable service discovery based on configuration.</Description>
<SuppressAspireIcon>true</SuppressAspireIcon>
<PackageIconFullPath>$(DefaultDotnetIconFullPath)</PackageIconFullPath>
</PropertyGroup>

<ItemGroup>
Expand Down