Update OpenAI integration to pass an ILogger to OpenTelemetry clients #7799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the OpenAI integration to pass an ILogger instance to the OpenTelemetry clients, ensuring that logging is correctly configured when telemetry is enabled. Key changes include:
- Adding tests to verify logging behavior for keyed and non-keyed OpenAI clients.
- Updating the production code to inject ILogger from the service provider in both embedding generator and chat client telemetry wrappers.
Reviewed Changes
| File | Description |
|---|---|
| tests/Aspire.OpenAI.Tests/AspireOpenAIClientBuilderChatClientExtensionsTests.cs | Added tests to validate logging configuration for chat clients |
| tests/Aspire.OpenAI.Tests/AspireOpenAIClientBuilderEmbeddingGeneratorExtensionsTests.cs | Added tests to validate logging configuration for embedding generators |
| src/Components/Aspire.OpenAI/AspireOpenAIClientBuilderEmbeddingGeneratorExtensions.cs | Injected ILogger for creating telemetry-wrapped embedding generators |
| src/Components/Aspire.OpenAI/AspireOpenAIClientBuilderChatClientExtensions.cs | Injected ILogger for creating telemetry-wrapped chat clients |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
tests/Aspire.OpenAI.Tests/AspireOpenAIClientBuilderChatClientExtensionsTests.cs
Show resolved
Hide resolved
tests/Aspire.OpenAI.Tests/AspireOpenAIClientBuilderEmbeddingGeneratorExtensionsTests.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 27, 2025
github-actions
bot
added
the
area-integrations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7771