Skip to content

Fix Windows CI #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix Windows CI #7761

merged 1 commit into from
Feb 25, 2025

Conversation

radical
Copy link
Member

@radical radical commented Feb 24, 2025

Tests for main on CI are failing on Windows_pipeline_tests-trx_3 - Aspire.Hosting.Tests.WaitForTests.WhenWaitBehaviorIsMissingWaitForResourceHealthyAsyncShouldUseDefaultWaitBehavior with:

Aspire.Hosting.DistributedApplicationException : Container runtime 'docker' was found but appears to be unhealthy. Ensure that Docker is running and that the Docker daemon is accessible. If Resource Saver mode is enabled, containers may not run. For more information, visit: https://docs.docker.com/desktop/use-desktop/resource-saver/

This is because of a missing RequiresDocker attribute on the test.

@Copilot Copilot AI review requested due to automatic review settings February 24, 2025 22:07
@radical radical requested a review from mitchdenny as a code owner February 24, 2025 22:07
Copilot
Copilot AI reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@radical radical requested a review from danmoseley February 24, 2025 22:07
@radical
Copy link
Member Author

radical commented Feb 24, 2025

@danmoseley @davidfowl breaks like this have been slipping through because we are not running tests on windows for PRs.

@radical
Copy link
Member Author

radical commented Feb 24, 2025

Failed build - https://dev.azure.com/dnceng-public/public/_build/results?buildId=960001&view=ms.vss-test-web.build-test-results-tab&runId=25556950&resultId=100431&paneView=debug

@radical
Copy link
Member Author

radical commented Feb 24, 2025

Validation build - https://dev.azure.com/dnceng-public/public/_build/results?buildId=961540&view=results

@radical radical requested a review from eerhardt February 24, 2025 22:46
eerhardt
eerhardt approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley danmoseley merged commit 6dc29e0 into dotnet:main Feb 25, 2025
76 checks passed
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@danmoseley danmoseley danmoseley approved these changes

@eerhardt eerhardt eerhardt approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @danmoseley @eerhardt