Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 18, 2024

Description

There was a regression in #6261. The children collection on a span view model wasn't populated, which prevented the collapse button from being displayed.

Fixed, and a test added.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Nov 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Member Author

JamesNK commented Nov 19, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK requested a review from mitchdenny November 20, 2024 03:29
@JamesNK JamesNK merged commit d0edcf4 into main Nov 21, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/fix-trace-detail-collapse branch November 21, 2024 23:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants