Improve devcontainer setup #6570
Conversation
dotnet-policy-service
bot
added
the
community-contribution
| // Use 'postCreateCommand' to run commands after the container is created. | ||
| "customizations": { | ||
| "vscode": { | ||
| "extensions": [ | ||
| "ms-dotnettools.csdevkit", | ||
| "ms-dotnettools.vscodeintellicode-csharp", |
There was a problem hiding this comment.
To sum up the discussions from the old PR:
- intellicode gives the user a better IntelliSense then without
- intelliCode depends on devkit so it's still their
| @@ -3,27 +3,28 @@ | |||
| { | |||
| "name": "C# (.NET)", | |||
| // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile | |||
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-9.0", | |||
| "image": "mcr.microsoft.com/devcontainers/dotnet:1-9.0-bookworm", | |||
There was a problem hiding this comment.
change docker base image to ubuntu
This is right now the only way I know to interact with windows sshd reliabel (for example if people want to use their local ssh config)
| } | ||
| }, | ||
|
|
||
| "hostRequirements": { | ||
| "cpus": 8, | ||
| "memory": "32gb", | ||
| "storage": "64gb" | ||
| }, |
There was a problem hiding this comment.
@mitchdenny this is maybe a problematic config. I was first surprised how fast the devcontainer is now half a year later. Actually it wasn't it was just bigger. So people that use the free tier of codespaces could easily run out of their free tier with this config, because it's overruling the defaults. (2 cores and 2GB RAM)
Maybe this should stay in the documentation
There was a problem hiding this comment.
This is really specific to this repo. We have a few test cases that spin up a lot of containers so this is about optimizing the development experience in our repo. When .NET 9.0 ships we'll probably start experimenting with devcontainer setups outside of our repo a bit more and figure out what a good minimum config is.
There was a problem hiding this comment.
I was thinking we should ship a devcontainer item template as part of this work.
|
Merging this in, I tried it out and it works well (also tried the dapr sample which might need more config to make the app ports be forwarded). |
github-actions
bot
added
the
needs-area-label
Description
Add the changes to the new
devcontainer.jsonthat were made in #3520 .Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):cc @davidfowl & @mitchdenny
Microsoft Reviewers: Open in CodeFlow