Enable Redis Logging #597
Merged
Enable Redis Logging #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
added
the
NO-MERGE
|
Converting to draft until we can figure out how to get a better startup experience without logging errors by default on F5. An issue is that DCP starts a proxy that accepts socket connections, but the real server isn't available yet, so the proxy closes the socket. This causes the Redis client to start logging errors that the socket has been closed. @karolz-ms is logging an issue for DCP to configure the proxy so it doesn't accept the socket until the server is ready. |
danmoseley
added
the
area-integrations
- the client library and otel packages have new versions, update to the latest - SE.Redis have ILogger support now, update to use it
|
The issue that was blocking this PR is now fixed with #886. |
sebastienros
approved these changes
Dec 5, 2023
eerhardt
removed
the
NO-MERGE
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Dec 6, 2023
This reverts commit d9e8e95. With dotnet@a3ed2b5, the proxyless container changes were reverted. Redis logging relied on these changes for a decent user experience. Reverting back to preview1 behavior until the proxyless container changes can be made again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE.Redis has ILogger support now, update to use it