Skip to content

[tests] Fixes to improve helix test runs hitting docker soft limits for network subnets #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2024
Merged

[tests] Fixes to improve helix test runs hitting docker soft limits for network subnets #5694

merged 5 commits into from
Sep 13, 2024

Conversation

radical
Copy link
Member

@radical radical commented Sep 12, 2024 •
edited
Loading

  • Disable parallel test runs on helix
    • This would help with too many docker network subnets being allocated in
      parallel, and thus hitting soft limits on the helix agents.
  • Prune docker networks on helix agents before/after the runs
Microsoft Reviewers: Open in CodeFlow

@radical
[tests] Disable parallel test runs on helix
0cb1e7d 
This would help with too many docker network subnets being allocated in
parallel, and thus hitting soft limits on the helix agents.
@ghost ghost added the area-components label Sep 12, 2024
@radical radical marked this pull request as ready for review September 12, 2024 18:32
@radical radical requested a review from eerhardt as a code owner September 12, 2024 18:32
@radical radical changed the title [tests] Disable parallel test runs on helix [tests] Fixes to improve helix test runs hitting docker soft limits Sep 12, 2024
@radical radical added area-engineering-systems infrastructure helix infra engineering repo stuff and removed area-components labels Sep 12, 2024
This was referenced Sep 12, 2024
Open
Closed
@radical radical changed the title [tests] Fixes to improve helix test runs hitting docker soft limits [tests] Fixes to improve helix test runs hitting docker soft limits for network subnets Sep 12, 2024
joperezr
joperezr reviewed Sep 12, 2024
View reviewed changes
joperezr
joperezr approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but looks good otherwise.

@radical radical enabled auto-merge (squash) September 13, 2024 07:00
@radical radical merged commit b5da17b into dotnet:main Sep 13, 2024
11 checks passed
@radical radical deleted the tests-run-parallel branch September 13, 2024 07:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

@danegsta danegsta Awaiting requested review from danegsta

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @joperezr