Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 3, 2024

Description

I started fixing a reported bug in the metrics area and found a bunch more while testing. They're all minor fixes and this PR rolls them up together.

Changes:

  • Meter list of instrument links now includes the selected duration and view in the link
  • Fix disabled headers on metrics and exemplars grids. Aspire headers should only be used when a header is resized/sorted.
  • Fix select duration not being correctly saved and restored from session state.
  • Fix JS error when navigating away from metrics graph. No impact on the app, but it's messy to have unnecessary JavaScript errors.

Fixes #5466

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@adamint adamint merged commit f739837 into main Sep 3, 2024
@adamint adamint deleted the jamesnk/metrics-bugfix-pass branch September 3, 2024 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

2 participants