Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 2, 2024

Description

Adds playwright tests to end-to-end test that validation works correctly.

Fixes #5512

Note: Builds on top of #5499. Can be reviewed now but should merge after #5499.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-dashboard label Sep 2, 2024
Base automatically changed from jamesnk/unsecured-auth-fix to main September 3, 2024 15:41
@radical
Copy link
Member

radical commented Sep 3, 2024

This has merge conflicts.

@JamesNK
Copy link
Member Author

JamesNK commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Member Author

JamesNK commented Sep 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit a218e5e into main Sep 4, 2024
11 checks passed
@JamesNK JamesNK deleted the jamesnk/authentication-playwright-tests branch September 4, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playwright test browser token authentication
3 participants