Skip to content

Conversation

davidebbo
Copy link
Contributor

@davidebbo davidebbo commented Aug 29, 2024

Description

See #5338.

We add support for multiple applicationUrl endpoints for the same scheme. e.g.

"applicationUrl": "https://localhost:p2;http://localhost:p0;http://localhost:p1;https://localhost:p3;https://localhost:p4"

Fixes #5338

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@davidebbo davidebbo requested a review from mitchdenny as a code owner August 29, 2024 14:58
@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Aug 29, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 29, 2024
@davidfowl davidfowl merged commit ccefa98 into dotnet:main Aug 29, 2024
11 checks passed
@davidebbo davidebbo deleted the issue-5338 branch August 30, 2024 06:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants