-
Notifications
You must be signed in to change notification settings - Fork 703
[tests] Add more playground apps #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0380ea
to
0bdbfeb
Compare
.WithBuildArg("GO_VERSION", goVersion) | ||
.WithBuildSecret("SECRET_ASENV", secret); | ||
.WithBuildSecret("SECRET_ASENV", secret) | ||
.WithEnvironment("DOCKER_BUILDKIT", "1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this here or in the MSBuild file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it here to have it close to where it is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have it in both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is set for tests running on the build machine (note to self: can be dropped now), and for basictests
on helix.
Microsoft Reviewers: Open in CodeFlow