Skip to content

Conversation

radical
Copy link
Member

@radical radical commented Aug 23, 2024

  • [tests] Add WithDockerfile playground app test
  • [tests] Add Kakfa playground app to tests
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 23, 2024
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-integrations Issues pertaining to Aspire Integrations packages labels Aug 23, 2024
@radical radical mentioned this pull request Aug 23, 2024
35 tasks
@radical radical force-pushed the withdockerfile-playground branch from d0380ea to 0bdbfeb Compare August 23, 2024 05:48
@radical radical requested review from eerhardt and joperezr August 23, 2024 22:46
@radical radical marked this pull request as ready for review August 24, 2024 00:00
@radical radical requested a review from mitchdenny as a code owner August 24, 2024 00:00
.WithBuildArg("GO_VERSION", goVersion)
.WithBuildSecret("SECRET_ASENV", secret);
.WithBuildSecret("SECRET_ASENV", secret)
.WithEnvironment("DOCKER_BUILDKIT", "1");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this here or in the MSBuild file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set it here to have it close to where it is needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have it in both places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set for tests running on the build machine (note to self: can be dropped now), and for basictests on helix.

@radical radical merged commit 7802ebe into dotnet:main Aug 27, 2024
@radical radical deleted the withdockerfile-playground branch August 27, 2024 19:58
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants