Adding public API test coverage for Aspire.Hosting.Valkey #5054
Conversation
ghost
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
radical
added
area-app-model
…-methods#aspire-hosting-valkey
| #region ValkeyBuilderExtensions | ||
|
|
||
| [Fact] | ||
| public void AddValkeyContainerShouldThrowsWhenBuilderIsNull() |
There was a problem hiding this comment.
nit: ShouldThrows -> ShouldThrow
|
|
||
| var action = () => builder.AddValkey(name); | ||
|
|
||
| Assert.Multiple(() => |
There was a problem hiding this comment.
Based on this comment. Assert.Multyple is not necessary.
You should just leave it here:
var exception = Assert.Throws(action);
Assert.Equal(nameof(builder), exception.ParamName);
Same for the code below
…-methods#aspire-hosting-valkey
…-methods#aspire-hosting-valkey
…-methods#aspire-hosting-valkey
bell-nat
changed the title
| [Fact] | ||
| public void AddValkeyContainerShouldThrowWhenNameIsNull() | ||
| { | ||
| IDistributedApplicationBuilder builder = new DistributedApplicationBuilder([]); |
There was a problem hiding this comment.
Use TestDistributedApplicationBuilder.Create();
| { | ||
| string name = null!; | ||
|
|
||
| var action = () => new ValkeyResource(name); |
There was a problem hiding this comment.
Add a static check in the class
private static string ThrowIfNull([NotNull] string? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
=> argument ?? throw new ArgumentNullException(paramName);
|
|
||
| public class ValkeyPublicApiTests | ||
| { | ||
| #region ValkeyBuilderExtensions |
…s#aspire-hosting-valkey
|
@bell-nat are you expecting to be able to finish this PR? if not, I will close it with thanks for the start. |
danmoseley
added
the
needs-author-action
|
This submission has been automatically marked as stale because it has been marked as requiring author action but has not had any activity for 14 days. |
Initial issues #2649
Issues Check List: Validate arguments of public methods
Microsoft Reviewers: Open in CodeFlow