Extract Aspire.Hosting.Oracle.Tests #4943

sebastienros · 2024-07-17T09:40:57Z

Contributes to #4294

Tests disabled because they don't work on the CI machines, c.f. #5362

Microsoft Reviewers: Open in CodeFlow

sebastienros · 2024-07-17T12:46:16Z

Based on the attempts I made to get the tested feature to work I think we should remove the features behind the two tests that are skipped there (and kept to show others what does not work IMO).

Meaning:

WithDataBindMount() which had issues with some passwords (special chars) and takes 5 minutes to start. (not sure it even works after that)
WithDbSetupBindMount() which doesn't read the files from the mount (test fails and docker logs shows the files are not taken into account). Could this be a limitation of the FREE version?

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs

# Conflicts: # tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj

src/Aspire.Hosting.Testing/ResourceLoggerForwarderService.cs

tests/Aspire.EndToEnd.Tests/IntegrationServicesTests.cs

tests/Aspire.Hosting.Oracle.Tests/AddOracleTests.cs

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs

tests/Aspire.Hosting.Oracle.Tests/Aspire.Hosting.Oracle.Tests.csproj

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs

# Conflicts: # Aspire.sln # tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs # tests/testproject/Common/TestResourceNames.cs

sebastienros · 2024-07-22T08:57:18Z

Aborting test run: test run timeout of 600000 milliseconds exceeded.

@radical tests are limited to 10 minutes apparently. Can we increase it for a test class?

radical · 2024-07-22T09:08:58Z

Aborting test run: test run timeout of 600000 milliseconds exceeded.
@radical tests are limited to 10 minutes apparently. Can we increase it for a test class?

You can have a per-project .runsettings file with a higher timeout. See https://github.com/radical/aspire/blob/751ed7161f20d4c8567c95b74f04ad8096d6d34d/tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj#L23
https://github.com/radical/aspire/blob/751ed7161f20d4c8567c95b74f04ad8096d6d34d/tests/Aspire.EndToEnd.Tests/.runsettings#L3-L6

tests/Aspire.Hosting.Oracle.Tests/OracleContainerFixture.cs

tests/testproject/TestProject.AppHost/TestProgram.cs

tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj

tests/testproject/TestProject.IntegrationServiceA/TestProject.IntegrationServiceA.csproj

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs

…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>

Co-authored-by: Eric Erhardt <[email protected]>

…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>

sebastienros · 2024-08-15T19:20:01Z

/azp run

azure-pipelines · 2024-08-15T19:20:13Z

Azure Pipelines successfully started running 1 pipeline(s).

sebastienros · 2024-08-16T14:32:56Z

/azp run

azure-pipelines · 2024-08-16T14:33:08Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # Aspire.sln

sebastienros · 2024-08-20T16:56:29Z

Disabled tests on CI since they don't work, filed an issue to track with current progress.

eerhardt

LGTM. We should be able to close #4294 when this is merged.

Extract Aspire.Hosting.Oracle.Tests

485fcdd

sebastienros requested a review from mitchdenny as a code owner July 17, 2024 09:40

ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 17, 2024

Merge branch 'main' into sebros/oracletests

ba3663b

sebastienros requested a review from eerhardt July 17, 2024 14:11

radical reviewed Jul 17, 2024

View reviewed changes

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs Outdated Show resolved Hide resolved

radical reviewed Jul 17, 2024

View reviewed changes

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs Outdated Show resolved Hide resolved

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs Outdated Show resolved Hide resolved

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs Outdated Show resolved Hide resolved

sebastienros added 2 commits July 19, 2024 01:08

Merge remote-tracking branch 'origin/main' into sebros/oracletests

56a2a4a

# Conflicts: # tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj

Remove E2E tests

d6a8d4b

sebastienros requested a review from ReubenBond as a code owner July 19, 2024 12:00

sebastienros added 3 commits July 19, 2024 05:44

Test folder permissions

b5a8713

Increase timeouts

c031eb1

Increase timeout

c74bdca

eerhardt reviewed Jul 19, 2024

View reviewed changes

tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs Outdated Show resolved Hide resolved

eerhardt mentioned this pull request Jul 19, 2024

Break up the TestProject to individual projects per Resource/component #4294

Closed

20 tasks

radical and others added 5 commits July 20, 2024 01:25

Merge remote-tracking branch 'origin/main' into sebros/oracletests

502fe09

# Conflicts: # Aspire.sln # tests/Aspire.EndToEnd.Tests/IntegrationServicesFixture.cs # tests/testproject/Common/TestResourceNames.cs

Add OracleContainerFixture

52b99e9

Merge remote-tracking branch 'origin/main' into sebros/oracletests

6b674e1

PR feedback

241db48

Fix unit test

60199dc

sebastienros added 2 commits July 22, 2024 05:44

Bum test timeout

5cf3c8f

Override runsettings file

f2eed7b

eerhardt reviewed Jul 22, 2024

View reviewed changes

tests/Aspire.Hosting.Oracle.Tests/OracleContainerFixture.cs Outdated Show resolved Hide resolved

eerhardt reviewed Jul 22, 2024

View reviewed changes

tests/testproject/TestProject.AppHost/TestProgram.cs Show resolved Hide resolved

sebastienros added 2 commits July 23, 2024 23:42

Remove project reference

084bef2

Merge branch 'main' into sebros/oracletests

0cd4b0a

sebastienros added 2 commits August 14, 2024 15:04

Merge remote-tracking branch 'origin/main' into sebros/oracletests

10a209d

Merge remote-tracking branch 'origin/main' into sebros/oracletests

3b017e0

eerhardt reviewed Aug 15, 2024

View reviewed changes

sebastienros and others added 6 commits August 15, 2024 09:45

Update tests/testproject/TestProject.IntegrationServiceA/TestProject.…

fee8b0b

…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>

Update tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj

402ab40

Co-authored-by: Eric Erhardt <[email protected]>

Update tests/Aspire.Hosting.Oracle.Tests/OracleFunctionalTests.cs

52fa7a1

Co-authored-by: Eric Erhardt <[email protected]>

Update OracleFunctionalTests.cs

b36e388

Update tests/testproject/TestProject.IntegrationServiceA/TestProject.…

9124b16

…IntegrationServiceA.csproj Co-authored-by: Eric Erhardt <[email protected]>

Update OracleFunctionalTests.cs

b16c864

sebastienros added 3 commits August 16, 2024 10:08

Merge remote-tracking branch 'origin/main' into sebros/oracletests

d869131

# Conflicts: # Aspire.sln

Remove CanConnectAsync

59b9dae

Wait for stopped instances

f5d9001

sebastienros added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 17, 2024

sebastienros force-pushed the sebros/oracletests branch from 6ed68e8 to af511f0 Compare August 17, 2024 02:02

build-analysis bot mentioned this pull request Aug 19, 2024

Failed to download file "https://dot.net/v1/dotnet-install.sh" dotnet/dnceng#3824

Open

3 tasks

sebastienros added 2 commits August 20, 2024 08:24

Disable functional tests

c3bb1b9

Merge remote-tracking branch 'origin/main' into sebros/oracletests

baacfe5

sebastienros force-pushed the sebros/oracletests branch from 172fcff to baacfe5 Compare August 20, 2024 15:24

sebastienros removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 20, 2024

sebastienros requested review from radical and eerhardt August 20, 2024 16:55

eerhardt approved these changes Aug 20, 2024

View reviewed changes

sebastienros merged commit d45778f into main Aug 20, 2024
11 checks passed

sebastienros deleted the sebros/oracletests branch August 20, 2024 17:59

github-actions bot locked and limited conversation to collaborators Sep 20, 2024

Extract Aspire.Hosting.Oracle.Tests #4943

Extract Aspire.Hosting.Oracle.Tests #4943

Uh oh!

Conversation

sebastienros commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

sebastienros commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Jul 22, 2024

Uh oh!

radical commented Jul 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Aug 15, 2024

Uh oh!

azure-pipelines bot commented Aug 15, 2024

Uh oh!

sebastienros commented Aug 16, 2024

Uh oh!

azure-pipelines bot commented Aug 16, 2024

Uh oh!

sebastienros commented Aug 20, 2024

Uh oh!

eerhardt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sebastienros commented Jul 17, 2024 •

edited

Loading

sebastienros commented Jul 17, 2024 •

edited

Loading