Rename eShopLite to TestShop #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-integrations
|
Is anyone going to read AspireShop and think it might represent something they should look at and copy from? That's why I was thinking of a more random name. |
|
✨ TestShop ✨ |
|
✨ BikeShedShop✨ |
eerhardt
commented
Feb 6, 2024
eerhardt
commented
Feb 6, 2024
|
Any thoughts here? I went with |
JamesNK
approved these changes
Feb 6, 2024
|
other than Violet 😄 ? testshop seems fine to me |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 7, 2024
* Rename eShopLite to TestShop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow