Fix service resolution logic in the dashboard #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were using the wrong name
ghost
added
the
|
We need unit tests in this area. I know priorities means it will have to wait, but it would give peace of mind that data is asserted is right without running the app and eyeballing it. |
JamesNK
approved these changes
Jan 31, 2024
|
We should be added them as we go. We need to start that refactoring |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
- We were using the wrong name
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
- We were using the wrong name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow