Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 2, 2024

Fixes #1463

  • Adds events to the span detail pane.
  • Adds extra content template to support displaying span event attributes when present
  • Updates span detail pane to use an accordion.
    • By default, high-level span details are open and application and span events are closed.
    • The accordion allows the pane to support more information. An alternative approach would be a tab control, but an accordion allows sections to be viewed side by side and feels more appropriate right now.
    • This UI or something similar will be needed in a resources detail pane in the future (i.e. a section for high-level resource information, a section for endpoints, a section for environment variables, etc)
  • Event count is visible in accordion if there are one or more events (so people know whether it is worth expanding event section).

image

Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Jan 2, 2024

cc @rolfik-mycronic @davidfowl

IsNameSortable="false"
IsValueSortable="false"
HighlightText="@_filter">
<ExtraValueContent>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot of what this looks like? I'm having trouble envisioning a property grid within a property grid value column given our information density already.

Copy link
Member Author

@JamesNK JamesNK Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Span events are rare. I've never seen events with attributes in the real world (I had to add some fake data to get the UI to show up). I don't expect this UI to be shown much at all.

I think it is Good Enough until there is feedback otherwise.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a header to make it clearer what the values are:

image

@@ -24,3 +24,19 @@
margin-bottom: 0;
}

::deep fluent-accordion-item {
border-color: transparent; /* A zero width border adds a horizontal scroll bar for some reason */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 that's weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@JamesNK JamesNK enabled auto-merge (squash) January 3, 2024 06:43
@JamesNK JamesNK merged commit 96fd8a1 into main Jan 3, 2024
@JamesNK JamesNK deleted the jamesnk/span-event branch January 3, 2024 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show trace events with attributes
3 participants