Skip to content

Fix types that shouldn't derive from container resource. (#1337) #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix types that shouldn't derive from container resource. (#1337) #1338

merged 1 commit into from
Dec 12, 2023

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Dec 11, 2023 •
edited by dotnet-policy-service bot
Loading

Backport of #1337

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Dec 11, 2023
@joperezr
Copy link
Member

@mitchdenny FWIW, you should now be able to just add a comment on the original PR like /backport to <targetBranchGoesHere> and that should automatically open the PR for you.

@DamianEdwards DamianEdwards added this to the preview 2 (Dec) milestone Dec 11, 2023
@mitchdenny
Copy link
Member Author

@joperezr Thanks!

DamianEdwards
DamianEdwards approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like this in preview.2 for sure, so we don't lead folks to treating these resources as containers and making customizations to them like volume mounts, etc. that won't be reflected in the manifest.

@davidfowl davidfowl merged commit 942a357 into release/8.0-preview2 Dec 12, 2023
@davidfowl davidfowl deleted the backport-1337 branch December 12, 2023 00:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
preview 2 (Dec)
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchdenny @joperezr @DamianEdwards @davidfowl