Rename view models in hosting layer #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
After the dashboard is split from the app host, it won't make sense to think of these as view models as there's no requirement that this data be used in a UI.
Like other `Aspire.Hosting` types in this change, the concept of "view model" no longer applies at this level. Rename the types accordingly.
drewnoakes
force-pushed
the
rename-view-models-in-hosting
branch
from
f35fba8 to
186f697
Compare
adamint
approved these changes
Dec 7, 2023
tlmii
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will be a gRPC connection between
Aspire.HostingandAspire.Dashboard. On the hosting side, there'll be no concept of view models any more.This change applies some renaming to better match the shape of APIs to come, reduce the size of the future PR that splits them across that boundary.