Avoid list copy on every update #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
By changing the set of subscriptions to an immutable collection and using optimistic locking to update it, we avoid having to copy the list of subscribers within a lock on every update, reducing allocations and the scope of synchronised blocks.
drewnoakes
force-pushed
the
avoid-copying-subscriber-list
branch
from
27876f8 to
30c54f6
Compare
smitpatel
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the set of subscriptions to an immutable collection and using optimistic locking to update it, we avoid having to copy the list of subscribers within a lock on every update, reducing allocations and the scope of synchronised blocks.